Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login: Support logging out of an account #948

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

chrisbobbe
Copy link
Collaborator

Screenshots coming soon. :)

Fixes: #463

@chrisbobbe
Copy link
Collaborator Author

imageimage

@chrisbobbe
Copy link
Collaborator Author

chrisbobbe commented Sep 17, 2024

This implements the logic where per-account routes on the nav are removed on logout, but it doesn't animate their exits; they just disappear suddenly. I think that's probably fine, and I didn't find a way to add the animation in.

To test a scenario where there are per-account routes when the logout happens, you can add a button to the "under construction" screen and copy-paste _logOutAccount into its press handler.

@chrisbobbe
Copy link
Collaborator Author

chrisbobbe commented Sep 17, 2024

Marked as a draft because in particular I think this may be lacking some test coverage that we'll want; for example, of the various if (maybeAccount == null) return;s added in PerAccountStore. But in that example, at least, I'm not sure if there might be a nicer way to write the app code. I added those early returns to avoid having ApiConnection.send get called after the ApiConnection was closed, which is a goal, as I think we discussed in the office on Friday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support logging out / forgetting about an account
1 participant