ui: Make some dark-theme adjustments from Greg's feedback #955
+74
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems like the preferred way to use the API.
An improvement that Greg pointed out: https://chat.zulip.org/#narrow/stream/48-mobile/topic/dark.20theme/near/1936853 This makes them the same color as the third-party login buttons, in 7c9c894.
Prompted by Greg's feedback that the dark-theme color was pretty dark: https://chat.zulip.org/#narrow/stream/48-mobile/topic/dark.20theme/near/1936853
Thanks to Greg for the reminder that this needed attention: https://chat.zulip.org/#narrow/stream/48-mobile/topic/dark.20theme/near/1936853 This is pretty low-contrast in dark mode, but as with many of our UI elements, we'll adjust as necessary when we have a design from Vlad.
chrisbobbe
added
the
integration review
|
Home page (light theme affected too because it was convenient to just plug in a light/dark pair of colors that comes from Material):
Error style (light theme unchanged):
Dot for muted unreads (light theme unchanged): The way this looks, I think it might not be an improvement, actually. The color matches what gets used on web, but it ends up with pretty low contrast because the background color differs between mobile and web. But also, like many UI elements that currently follow web, this is something we'll revisit once we have a design from Vlad.
|
|
cc @alya in case you'd like to take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses all the remaining items in the CZO thread at https://chat.zulip.org/#narrow/stream/48-mobile/topic/dark.20theme/near/1936853 .
Screenshots coming soon.