api: Use 'direct' instead of 'private' in POST /messages, when supported #5728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
added
P1 high-priority
api migrations
server release goal
|
Tested by sending a 1:1 PM and a group PM on chat.zulip.org (feature level 177) and recurse.zulipchat.com (feature level 172). (The threshold for the updated API is feature level 174.) |
gnprice
removed
P1 high-priority
server release goal
|
Thanks! Relabeling because this isn't a server release goal — whether or not we've done this at the time of release will be invisible to users. |
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
May 23, 2023
As mentioned in the issue, there are various variable names that still use "private messages"; we're leaving those be for now. PR zulip#5728 is open for a related API migration: to use 'direct' instead of 'private' in POST /messages, when supported. Fixes: zulip#5731
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
May 25, 2023
As mentioned in the issue, there are various variable names that still use "private messages"; we're leaving those be for now. PR zulip#5728 is open for a related API migration: to use 'direct' instead of 'private' in POST /messages, when supported. Fixes: zulip#5731
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
May 25, 2023
As mentioned in the issue, there are various variable names that still use "private messages"; we're leaving those be for now. PR zulip#5728 is open for a related API migration: to use 'direct' instead of 'private' in POST /messages, when supported. Fixes: zulip#5731
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5725