ios [nfc]: Cut notifications library out of handling "initial notification" #5740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on my iPhone 13 Pro running iOS 16. |
…ation" And handle it ourselves, through our dedicated iOS native module ZLPNotificationsStatus. (The "initial notification" is a notification that, by being tapped, launched the app from cold. PR zulip#5676 was about notifications that are tapped when the app is already open, and that PR fixed a known bug.) This, like zulip#5676, makes our iOS notification handling more transparent. My hope is to smooth the path to custom iOS notification code in zulip-flutter (zulip-flutter#122, etc.) by demonstrating a working implementation that's simple and avoids depending on the details of @react-native-community/push-notification-ios. Cutting the library out of this codepath makes one small difference in the payload we pass to `fromAPNs` on the JS side: the `aps` property is now present. (So, remove a comment saying it might be absent). We've never looked at that property, so this is NFC. Unlike in 2ae6f79 / zulip#5676, there wasn't a call to the library's custom RCTConvert extensions to account for, as we did there with a cautious call to RCTJSONClean.
chrisbobbe
force-pushed
the
pr-ios-notif-transparency
branch
from
3169cf4
to
70e6531
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm thinking that for iOS notifications in
zulip-flutter(zulip/zulip-flutter#122, etc.), it'll help to demonstrate a working implementation that doesn't depend on@react-native-community/push-notification-ios, since that library's code can be unnecessarily opaque, and also buggy.#5676 took a first step toward that, and this takes another step. (The former was about tapping a notification when the app is already open; this PR is in the code for tapping a notification when the app is closed.)