Unify confirmation popups into popup framework #1534
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why?
This incrementally improves the popup code until a point where the confirmation popups can be handled in the same way as others and improved upon:
PopUpFrame
class in view.pyPopUpFrame
to handle title-less cases (ie. for confirmation popups)ConfirmationPopUpView
from anOverlay
to aFrame
, and other changes to enable use ofshow_pop_up
just like other popupsOther than simplifying the code, this also results in confirmation popups acquiring a solid edge, as with regular popups.
Outstanding aspect(s)
External discussion & connections
topic
How did you test this?
Self-review checklist for each commit
Visual changes