Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling Empty Narrows #1543

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Commits on Aug 3, 2024

  1. boxes: On opening application, display an empty recipient bar.

    It was previously showing a text "DONT HIDE".
    Niloth-p committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    4992dbe View commit details
    Browse the repository at this point in the history
  2. core: Track if the current narrow is empty.

    Co-authored-by: Sumanth V Rao <[email protected]>
    Niloth-p and sumanthvrao committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    936cf2f View commit details
    Browse the repository at this point in the history
  3. messages/views: Disable keypresses from dummy messages.

    Updated tests.
    Niloth-p committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    6cac57d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f8503f8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    dcb213a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0fb5bf0 View commit details
    Browse the repository at this point in the history
  7. messages: Remove error handling for unreachable case.

    Message type can only be "stream" or "private", as returned by the API.
    
    Simplified the flow to bunch if-else blocks together.
    
    Test removed.
    Niloth-p committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    df2feb4 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    299a1c1 View commit details
    Browse the repository at this point in the history
  9. utils/messages: Add a dummy message for empty narrows.

    Tests updated.
    
    Co-authored-by: Sumanth V Rao <[email protected]>
    Niloth-p and sumanthvrao committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    3444552 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Configuration menu
    Copy the full SHA
    2a66297 View commit details
    Browse the repository at this point in the history