Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add command: Add general labels when specific labels are added. #236

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NickZumb
Copy link

This adds the relevant general area labels whenever a specific area label is added with the "add" command.

Co-authored-by: Skyler Simpson
Fixes #29739.

Implements requested feature from zulip/zulip#29739 (comment)
This passes all zulipbot tests, but I have been unable to get a local copy of the bot working, so I have not tested its functionality.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Merging #236 (2623eac) into main (dd069d3) will increase coverage by 0.30%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
+ Coverage   64.25%   64.55%   +0.30%     
==========================================
  Files          23       23              
  Lines        1757     1772      +15     
==========================================
+ Hits         1129     1144      +15     
  Misses        628      628              

@zulipbot zulipbot added size: M and removed size: S labels Apr 23, 2024
This adds the relevant general area labels whenever a specific area
label is added with the "add" command.

adds a test case for this feature

Co-authored-by: Skyler Simpson
Fixes #29739.
@NickZumb
Copy link
Author

I added a unit test. Still can't get a local bot copy working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants