Fix for: Issue 238 - Bug: Batch Update with Inheritance

[novamxd]

All the changes I did. Hopefully I did this pull request/forking right... I've never played with this part of Git Hub before.

[JonathanMagnan]

Oh damn... 160 file modified ;)

I will look at it this week

Best Regards,

Jonathan

[novamxd]

Yea it might have been a bit of an interesting project.

[JonathanMagnan]

Hello @novamxd ,

I have started to investigate it. I made some quick test and it seems to work very fine.

There is some additional code that I will add since some people will want to use the features like this:

int intRowsAffected2 = tcContext.Inheritance_TPC_Animals.Update(i => new Inheritance_TPC_Dog()
{
	ColumnInt = 1
});

Most context normally doesn't have a DbSet for Inheritance_TPC_Dogs

I will probably have to split the EF5|EF6 code from EF Core as a one point, there is not enough thing similar and it make it very hard to maintain.

Time is currently heavily missing but I hope to be able to complete the integration before the end of the month.

Best Regards,

Jonathan

[novamxd]

Hey @JonathanMagnan ,

Ok, so long as you don't remove the ability to delete from the sub classes then that works. Realistically speaking I don't know why someone would use TPC if they're not going to reference the sub-classes, as that's the point. Being a DBA I can say that if they wanted the approach you're speaking of, they're likely to go down the TPH route instead, which is already supported with the update I made.

Also did you want a hand splitting up the EF5/6 and Core libraries? I was pretty tempted to do that as part of this update but figured it would just complicate the update.

Regards

[JonathanMagnan]

Hello @novamxd ,

You might be very surprised with all kind of context I have viewed so far ;)

A lot of people doesn't reference sub-classes (and some are not even aware they could do it), so that's for sure something that need to be supported.

Thank a lot of your help proposition, I believe for this one, it's better I try to do it by merging some of your work to make sure I understand all the code you added, that will make it easier to support it later.

Best Regards,

Jonathan

[novamxd]

Hey @JonathanMagnan ,

Do they reference sub-classes with TPC or TPH? Like I said, using the base class with TPH makes sense and I've seen lots of examples for that. To use that with TPC would seem strange, but again, so long as the batch functions work with the sub-classes, I honestly am indifferent.

As for the update and splitting, I agree that getting familiar with the update is the best approach. But if after you finish the merge you want a hand splitting up the libraries, just let me know.

Regards

[JonathanMagnan]

To make it short, people do everything in every possible way that you may never think ;)

[ashishakm]

I am using Asp.net mvc and doing operation like e.g.
DbContext.Tasks
.Where(t => t.StatusId == 1)
.Update(t => new Task { StatusId = 2 });

I am using Entityframework.Plus library for audit but update is not working other than this new insertion is working fine. I am overriding savechanges() for audit. please on this

[chrfin]

@JonathanMagnan Is there still progress on this? Having the same problem here...

[JonathanMagnan]

Should already be fixed in https://entityframework-extensions.net/

DeleteFromQuery and UpdateFromQuery are free (which is the same as Batch Delete and Batch Update here), but be careful, otherwise features are paid.

There is currently no short term plan to make a fix on EF Plus at this moment.

[chrfin]

Thanks, did work :-)