Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UAVCAN hardpoint control #4361

Closed

Conversation

pavel-kirienko
Copy link
Contributor

Controlling OpenGrab EPM (electropermanent magnet) and (in theory) other compatible grabbers via UAVCAN.

These changes depend on ArduPilot/archived-PX4Firmware#57, although they can be merged separately - nothing will break, the feature just will not work.

FYI @ctech4285 @silverburn

@gmorph
Copy link
Contributor

gmorph commented Jun 22, 2016

Do you have a link so we can see a picture of the electro grabber?
You have a number of white space changes in the commit which make it harder to review. Any chance you could update the commit with just the code changes? "git add -p" is your friend :-)
Thanks, Grant.

@pavel-kirienko pavel-kirienko force-pushed the uavcan_hardpoint_control branch from b473ff3 to 29848fc Compare June 23, 2016 23:48
@pavel-kirienko
Copy link
Contributor Author

Info about the grabber: https://docs.zubax.com/opengrab_epm_v3

The commits have been squashed and whitespace changes reverted. I don't understand though how whitespaces make changesets harder to review - ?w=1 at the end of the URL is your friend ;)

Let me know if there's something else that needs to be fixed.

Thanks!

@pavel-kirienko
Copy link
Contributor Author

This is a quick reminder that this PR is ready to be merged.

@ctech4285
Copy link
Contributor

Yeab I would very much like to see this merged pretty please

@silverburn
Copy link

Yeah, be really keen to be picked up too.

@tridge
Copy link
Contributor

tridge commented Aug 4, 2016

thanks Pavel! I tested here and it looks good. Merged.

@tridge tridge closed this Aug 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants