Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fabric E2E Sample] Improving README.md #1081

Conversation

promisinganuj
Copy link
Contributor

Type of PR

  • Documentation changes

Purpose

  • To improve README.md

Does this introduce a breaking change? If yes, details on what can break

No breaking changes

Author pre-publish checklist

  • Added test to prove my fix is effective or new feature works
  • No PII in logs
  • Made corresponding changes to the documentation

Issues Closed or Referenced

@promisinganuj promisinganuj added documentation Improvements or additions to documentation e2e: fabric Related with E2E Fabric Sample labels Feb 5, 2025
@promisinganuj promisinganuj self-assigned this Feb 5, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

Files not reviewed (1)
  • e2e_samples/fabric_dataops_sample/scripts/cleanup_infrastructure.sh: Language not supported
Comments suppressed due to low confidence (4)

e2e_samples/fabric_dataops_sample/README.md:85

  • The term 'Workspace' should be 'workspace' for consistency.
Prod Workspace**.

e2e_samples/fabric_dataops_sample/README.md:184

  • The phrase 'service principal or managed identity' should be 'service principal or managed identity's' for grammatical correctness.
service principal or managed identity

e2e_samples/fabric_dataops_sample/README.md:269

  • The term 'Object ID' should be 'object ID' for consistency.
Object ID

e2e_samples/fabric_dataops_sample/README.md:423

  • The phrase 'Note that the branches will be recreated when you run the prepare_azure_repo.sh script again.' should be 'Note that the branches will be recreated when you run the prepare_azure_repo.sh script again.' for grammatical correctness.
Note that the branches will be recreated when you run the [prepare_azure_repo.sh](./prepare_azure_repo.sh) script again.

e2e_samples/fabric_dataops_sample/README.md Outdated Show resolved Hide resolved
e2e_samples/fabric_dataops_sample/README.md Outdated Show resolved Hide resolved
e2e_samples/fabric_dataops_sample/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@naga-nandyala naga-nandyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@promisinganuj promisinganuj merged commit ef260f3 into feat/e2e-fabric-dataops-sample-v0-2 Feb 10, 2025
3 checks passed
@promisinganuj promisinganuj deleted the promisinganuj/894-975-readme-known-issues branch February 11, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation e2e: fabric Related with E2E Fabric Sample
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants