-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fabric E2E Sample] Improving README.md #1081
[Fabric E2E Sample] Improving README.md #1081
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
Files not reviewed (1)
- e2e_samples/fabric_dataops_sample/scripts/cleanup_infrastructure.sh: Language not supported
Comments suppressed due to low confidence (4)
e2e_samples/fabric_dataops_sample/README.md:85
- The term 'Workspace' should be 'workspace' for consistency.
Prod Workspace**.
e2e_samples/fabric_dataops_sample/README.md:184
- The phrase 'service principal or managed identity' should be 'service principal or managed identity's' for grammatical correctness.
service principal or managed identity
e2e_samples/fabric_dataops_sample/README.md:269
- The term 'Object ID' should be 'object ID' for consistency.
Object ID
e2e_samples/fabric_dataops_sample/README.md:423
- The phrase 'Note that the branches will be recreated when you run the prepare_azure_repo.sh script again.' should be 'Note that the branches will be recreated when you run the prepare_azure_repo.sh script again.' for grammatical correctness.
Note that the branches will be recreated when you run the [prepare_azure_repo.sh](./prepare_azure_repo.sh) script again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
ef260f3
into
feat/e2e-fabric-dataops-sample-v0-2
Type of PR
Purpose
Does this introduce a breaking change? If yes, details on what can break
No breaking changes
Author pre-publish checklist
Issues Closed or Referenced