Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Example app web README #231

Merged

Conversation

Kicu
Copy link
Contributor

@Kicu Kicu commented Jan 8, 2025

Details

  • updates README for Example App, to mention usage of npm on top level; if one uses yarn there are webpack errors there
  • regenerated yarn.lock inside /Example

What this fixes

It makes it more clear how to run web Example

Checklist

  • I have described the bug/issue
  • I have provided reproduction in Example App
  • I have tested that solution works on Example App on all platforms:
    • Android
    • iOS
    • Web

Screenshots/Videos

Copy link

github-actions bot commented Jan 8, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Kicu Kicu mentioned this pull request Jan 8, 2025
3 tasks
@Kicu
Copy link
Contributor Author

Kicu commented Jan 8, 2025

@mountiny 🙏 this breaks nothing, just docs and lockfiles

@gedu
Copy link
Contributor

gedu commented Jan 8, 2025

LGTM, that is the flow I have to take to run the Example app

@Kicu
Copy link
Contributor Author

Kicu commented Jan 8, 2025

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

CLABotify added a commit to Expensify/CLA that referenced this pull request Jan 8, 2025
@mountiny mountiny merged commit 562f7a9 into Expensify:main Jan 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants