Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: interface health anomaly fields and term #1009

Open
wants to merge 2 commits into
base: jcloud
Choose a base branch
from

Conversation

rahul-kriplani-jnpr
Copy link

  • in-mbps
  • out-mbps
  • in-errors-count
  • out-errors-count
  • fec-corrected
  • fec-uncorrected
  • input-crc-errors
  • framing-errros
  • output-crc-errors
  • optical-temp
  • optics-tx-power
  • optics-rx-power

- in-mbps
- out-mbps
- in-errors-count
- out-errors-count
- fec-corrected
- fec-uncorrected
- input-crc-errors
- framing-errros
- output-crc-errors
- optical-temp
- optics-tx-power
- optics-rx-power
@healthbot-ci
Copy link
Collaborator

Only Juniper employees can contribute to juniper_official folder. If you are one follow the steps mentioned in the README else, contribute to the community_supplied directory. Make the necessary changes and commit again.

Copy link
Collaborator

@vvikramb vvikramb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Order of terms needs to be changed for anomaly term to execute, if green or red condition are met then yellow term will not execute,please refer check-fpc-cpu-memory-state-temp rule.
Also check Enabling "Evalute next term".

@rahul-kriplani-jnpr
Copy link
Author

Order of terms needs to be changed for anomaly term to execute, if green or red condition are met then yellow term will not execute,please refer check-fpc-cpu-memory-state-temp rule. Also check Enabling "Evalute next term".

what should be the order in ideal case? green -> yellow -> red?
also where can I check/read Enabling "Evalute next term"?

first check alarm then warning and afterwards check for normal and anomalous
@healthbot-ci
Copy link
Collaborator

Only Juniper employees can contribute to juniper_official folder. If you are one follow the steps mentioned in the README else, contribute to the community_supplied directory. Make the necessary changes and commit again.

Comment on lines +184 to +197
/*
* Sets color to yellow when fec-corrected-errors is not in between predicted range.
*/
term is-fec-corrected-errors-anomalous {
when {
equal-to "$fec-corrected-anomaly" 1;
}
then {
status {
color yellow;
message "$interface-name, FEC corrected errors $fec-corrected is not between the predicted range of ($fec-corrected-anomaly-lower-boundary) and ($fec-corrected-anomaly-upper-boundary)";
}
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this I should use next?
what will be the correct syntax?
then {
next {
? the next term, define it or just use its name?

@rahul-kriplani-jnpr
Copy link
Author

Order of terms needs to be changed for anomaly term to execute, if green or red condition are met then yellow term will not execute,please refer check-fpc-cpu-memory-state-temp rule. Also check Enabling "Evalute next term".

I have reordered terms for below triggers:





can you please verify if they makes sense or what needs to be updated.

For other triggers where I have added anomaly terms seems like require a next action but I am not sure how to write it. Can you also help in those cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants