-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: interface health anomaly fields and term #1009
Open
rahul-kriplani-jnpr
wants to merge
3
commits into
Juniper:jcloud
Choose a base branch
from
rahul-kriplani-jnpr:feature/COL-1315/interface_health_anomaly_rules
base: jcloud
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+340
−46
Open
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for this I should use next?
what will be the correct syntax?
then {
next {
? the next term, define it or just use its name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can anomaly be 1 when green condition is met?If yes then enable "Evalute next term" for both the green and red terms else only for the red term.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anomaly can be 1 for both green and red.
the user guide talks about enabling evaluate next term from UI, how to enable it programatically from the rule?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can do it through mgd, something like this :
rule test {
trigger testing {
term test {
then {
next;
}
}
}
}
Also check below points
Enable "Evaluate next terms" for interface-input-errors and interface-output-errors triggers in "check-interface-in-out-errors-traffic-state-flaps" rule
For "check-optical-signal-loss-fec-tx-rx-power",no need to change the order of red and yellow terms, just add the anomaly term before the red terms and enable "Evalute next term" in previous and anomaly terms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For
check-optical-signal-loss-fec-tx-rx-power.rule
the triggers interface-optical-rx-power and interface-optical-tx-power has two red terms, so I have added anomaly term before the first red term.