bug/issue 144 check CE registry before assuming a custom element definition exists #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
changed the title
thescientist13
commented
Feb 19, 2024
src/dom-shim.js
Outdated
| } | ||
|
|
||
| get(tagName) { | ||
| return this.customElementsRegistry[tagName]; | ||
| if (this.customElementsRegistry.get(tagName)) { |
There was a problem hiding this comment.
shouldn't we use .has here instead?
if (this.customElementsRegistry.has(tagName)) {
return this.customElementsRegistry.get(tagName);
} else {
// ...
}There was a problem hiding this comment.
No, since CustomElementsRegistry does not expose a has method
https://developer.mozilla.org/en-US/docs/Web/API/CustomElementRegistry
thescientist13
changed the title
thescientist13
force-pushed
the
bug/issue-144-check-registry-before-reusing-a-custom-element-definition
branch
from
1e3b651
to
057acf3
Compare
thescientist13
deleted the
bug/issue-144-check-registry-before-reusing-a-custom-element-definition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #144
greenwood-wcc-element-instance-no-shadow-root-working.mov
Summary of Changes
customElementsRegistryfor checking if a custom element definition existscustomElementsRegistryto be a setSee #145 for more on this topic