bug/issue 144 check CE registry before assuming a custom element definition exists

src/dom-shim.js

@@ -9,7 +9,7 @@
 
 // https://developer.mozilla.org/en-US/docs/Web/API/Node
 // EventTarget <- Node
 // TODO should be an interface?
 class Node extends EventTarget {
   // eslint-disable-next-line
   cloneNode(deep) {
@@ -104,7 +104,7 @@
     this.content = new DocumentFragment();
   }
 
   // TODO open vs closed shadow root
   set innerHTML(html) {
     if (this.content) {
       this.content.innerHTML = `
@@ -123,15 +123,20 @@
 // https://developer.mozilla.org/en-US/docs/Web/API/CustomElementRegistry
 class CustomElementsRegistry {
   constructor() {
-    this.customElementsRegistry = {};
+    // TODO this should probably be a set or otherwise follow the spec?
+    // https://github.com/ProjectEvergreen/wcc/discussions/145
+    this.customElementsRegistry = new Map();
   }
 
   define(tagName, BaseClass) {
-    this.customElementsRegistry[tagName] = BaseClass;
+    // TODO this should probably fail as per the spec...
+    // e.g. if(this.customElementsRegistry.get(tagName))
+    // https://github.com/ProjectEvergreen/wcc/discussions/145
+    this.customElementsRegistry.set(tagName, BaseClass);
   }
 
   get(tagName) {
-    return this.customElementsRegistry[tagName];
+    return this.customElementsRegistry.get(tagName);
   }
 }
 

src/wcc.js

@@ -134,9 +134,7 @@ async function initializeCustomElement(elementURL, tagName, attrs = [], definiti
 
   // https://github.com/ProjectEvergreen/wcc/pull/67/files#r902061804
   const { pathname } = elementURL;
-  const element = tagName
-    ? customElements.get(tagName)
-    : (await import(pathname)).default;
+  const element = customElements.get(tagName) ?? (await import(pathname)).default;
   const dataLoader = (await import(pathname)).getData;
   const data = props
     ? props