Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/issue 158 preserve query params when loading modules #159

Merged
merged 2 commits into from
Apr 12, 2024
Merged

bug/issue 158 preserve query params when loading modules #159

merged 2 commits into from
Apr 12, 2024

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Apr 10, 2024 •
edited
Loading

Related Issue

resolves #158

Summary of Changes

  1. Use href instead of pathname to better honor original URL passed to WCC

Would probably try and figure out a way to test this, but since this will all get refactored soon anyway ( #134 ) not going to worry about it too much right now.

@thescientist13 thescientist13 added the bug Something isn't working label Apr 10, 2024
@thescientist13 thescientist13 changed the title preserver query params when loading modules bug/issue 158 preserve query params when loading modules Apr 10, 2024
@thescientist13 thescientist13 merged commit ef5bb27 into master Apr 12, 2024
12 checks passed
@thescientist13 thescientist13 deleted the bug/issue-158-preserve-query-params-when-loading-modules branch April 12, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WCC dropping query params when loading module URLs
1 participant
@thescientist13