Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/issue 158 preserve query params when loading modules #159

Merged
merged 2 commits into from
Apr 12, 2024
Merged

bug/issue 158 preserve query params when loading modules #159

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff3beb8
preserver query params when loading modules
thescientist13 Apr 10, 2024
5c5770f
add historical comment
thescientist13 Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/wcc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,10 @@ async function initializeCustomElement(elementURL, tagName, attrs = [], definiti
}

// https://github.com/ProjectEvergreen/wcc/pull/67/files#r902061804
const { pathname } = elementURL;
const element = customElements.get(tagName) ?? (await import(pathname)).default;
const dataLoader = (await import(pathname)).getData;
// https://github.com/ProjectEvergreen/wcc/pull/159
const { href } = elementURL;
const element = customElements.get(tagName) ?? (await import(href)).default;
const dataLoader = (await import(href)).getData;
const data = props
? props
: dataLoader
Expand Down
Loading