Fix Negative Requeue Duration in getStatusCheckDelay

[OdedViner]

This PR fixes an issue in the getStatusCheckDelay function where a negative requeue duration could be returned if the scheduled time had already passed. The fix ensures that if the computed remaining time is negative, the function returns 0 to trigger an immediate requeue instead of a negative duration.

Changes:

• Added a check to prevent negative requeue durations.

• If the computed duration is negative, it now returns 0.

This improves the stability of the reconciliation loop and prevents unexpected scheduling behavior.

Fix: #1838

[nirs]

The fix looks good but the tests is 5 times more complicated than the code it tests and will be hard to maintain.

How controller runtime handle negative requeue time? maybe it already clip the value to 0 and does the right thing? If it does, we don't need to complicate the code.

[nirs]

This file is in the controller_test package, which is good for black box testing. For testing a private function we can use a test using the controllers package.

[nirs]

The fix is trivial but testing is it hard and will take time to get right. I would separate the test to another PR and merge the trivial fix now.

[nirs]

@OdedViner please squash the commits

[OdedViner]

@OdedViner please squash the commits

done

[nirs]

We can simplify this to:

return max(0, remaining)

[OdedViner]

done