Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Negative Requeue Duration in getStatusCheckDelay #1841

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Fix Negative Requeue Duration in getStatusCheckDelay #1841

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion internal/controller/drplacementcontrol_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1257,7 +1257,10 @@ func (r *DRPlacementControlReconciler) getStatusCheckDelay(
// iteration of the reconcile loop. Hence, the next attempt to update the
// status should be after the remaining duration of this polling interval has
// elapsed: (beforeProcessing + StatusCheckDelay - time.Now())
return time.Until(beforeProcessing.Add(StatusCheckDelay))
// If the scheduled time is already in the past, requeue immediately.
remaining := time.Until(beforeProcessing.Add(StatusCheckDelay))

return max(0, remaining)
}

// updateDRPCStatus updates the DRPC sub-resource status with,
Expand Down