Remove cache server test download #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BetsyMcPhail
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
Has this been tested out on an experimental job to catch any typos, etc. ?
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @tyler-yankee)
|
Yeah, was just waiting on that job to finish. mac-arm-sequoia-clang-cmake-experimental-release is happy. |
BetsyMcPhail
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working through #22587 it was determined that this section of code doesn't really make sense in general. It tests a download from the cache server and opts to not use it if the download fails, rather than failing the entire build. But the entire build should just fail at that point; this way, errors are easier to track down.
This change is