Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[drake_cmake_external] Add test case to disable solver #370

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tyler-yankee
Copy link
Collaborator

@tyler-yankee tyler-yankee commented Feb 13, 2025

Addresses #22547. See #22626 for the change on Drake. This change adds a unit test to drake_cmake_external to test by disabling the CSDP solver.

Tested locally by changing the URL pointed to by ExternalProject_Add(drake) to the feature branch on Drake.


This change is Reviewable

Copy link
Collaborator Author

@tyler-yankee tyler-yankee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@jwnimmer-tri for feature review, please!

Reviewable status: all discussions resolved, LGTM missing from assignee jwnimmer-tri, platform LGTM missing (waiting on @jwnimmer-tri)

Copy link
Collaborator Author

@tyler-yankee tyler-yankee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the CI failure in Jenkins is expected, since it's using Drake master which doesn't yet have the CMake solver opt-out flags.

Reviewable status: all discussions resolved, LGTM missing from assignee jwnimmer-tri, platform LGTM missing (waiting on @jwnimmer-tri)

@jwnimmer-tri
Copy link
Contributor

Note that the CI failure in Jenkins is expected, since it's using Drake master which doesn't yet have the CMake solver opt-out flags.

A nice tool we sometimes use in cases like this is to temporarily add a commit here that re-points Drake to the pull request instead of master, so CI here will shine light. Then after the Drake PR lands, we revert that edit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants