-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GECKO 3.2.0 #381
Merged
GECKO 3.2.0 #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g up protein pool exchange and proteomics integrated, adjusting 'percUsage' accordingly.
…g up protein pool exchange and proteomics integrated, adjusting 'percUsage' accordingly.
- use fluxes from usageData - give protein pool in usageReport instead of printing to command window
Update ProtPool Calculation by Including usage_prot_ Reaction Fluxes
* fix: loadDatabases error when uniprot dl fails * chore: updateDocumentation * chore: update Actions dependency and trying to fix an issue: https://stackoverflow.com/questions/70435286/resource-not-accessible-by-integration-on-github-post-repos-owner-repo-ac * fix: calculateFfactor read header in paxDB.tsv sometimes, the first # in the file is missed * chore: updateGECKOdoc * fix: runDLKcat parse full paths * fix: applyKcatConstraints if all kcat are zero * fix: getStandardKcat also if enzyme is missing * feat: removeStandardKcat new function * chore: RAVEN release 2.9.1 as dependency
* fix: calculateFfactor can take protData input * feat: constrainEnzConcs keep prot pool draw addresses #375 * fix: updateProtPool obsolete * doc: update full_ecModel for prot_usage rxns * fix: enzymeUsage correct mention of output units solves #376 * doc: updateGECKOdoc * doc: update README.md with protocol change * fix: README.md link
This PR has been automatically tested with GH Actions. Here is the output of the tests:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main improvements in this PR:
loadDatabases
clarifies what to do if download from UniProt failscalculateFfactor
sometimes failed to properly readpaxDB.tsv
filesrunDLKcat
should parseparams.path
as absolute paths to docker (solves runDLKcat() cannot find path to data #378applyKcatConstraints
can handle when all kcat are zerogetStandardKcat
should also assign standard kcat values for reactions that do have a non-emptygrRules
field, but are not inmodel.ec
due to the genes not matching any of the enzymes in theuniprot.tsv
filecalculateFfactor
can take protData inputenzymeUsage
correct mention of output units enzyme usage unit #376updateProtPool
is made obsolete new in GECKO 3.2.0: protein usage reactions always draw from protein pool, also when proteomics is integrated #375removeStandardKcat
function removes all traces ofgetStandardKcat
having modified a modelInstructions on merging this PR:
develop
as target branch, and will be resolved with a squash-merge.main
as target branch, and will be resolved with a merge commit.