std::equal is not necessarily constexpr in C++17, so PR #474 broke ad…

…a technically.
ada-url · Sep 19, 2023 · 4f38277 · 4f38277
1 parent f4dc343
commit 4f38277
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/include/ada/checkers-inl.h b/include/ada/checkers-inl.h
@@ -54,9 +54,10 @@ inline constexpr bool is_normalized_windows_drive_letter(
   return input.size() >= 2 && (is_alpha(input[0]) && (input[1] == ':'));
 }
 
-ada_really_inline constexpr bool begins_with(std::string_view view,
+ada_really_inline bool begins_with(std::string_view view,
                                              std::string_view prefix) {
   // in C++20, you have view.begins_with(prefix)
+  // std::equal is constexpr in C++20
   return view.size() >= prefix.size() &&
          std::equal(prefix.begin(), prefix.end(), view.begin());
 }

diff --git a/include/ada/checkers.h b/include/ada/checkers.h
@@ -70,9 +70,9 @@ inline constexpr bool is_normalized_windows_drive_letter(
     std::string_view input) noexcept;
 
 /**
- * @warning Will be removed when Ada supports C++20.
+ * @warning Will be removed when Ada requires C++20.
  */
-ada_really_inline constexpr bool begins_with(std::string_view view,
+ada_really_inline bool begins_with(std::string_view view,
                                              std::string_view prefix);
 
 /**