Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: reproduce node.js bug #511

Merged
merged 4 commits into from
Sep 19, 2023
Merged

test: reproduce node.js bug #511

merged 4 commits into from
Sep 19, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Sep 18, 2023

Passing set_host("::") produces invalid URL. Therefore, it is causing Node.js to fail on the next setter.

PS: Safari doesn't have this bug.

{
	const url = new URL('http://foo')
	url.host = '::' // does *not* crash
	url.port = 3000 // crashes with the described error below
}

Ref: nodejs/node#49650

@anonrig anonrig merged commit f4dc343 into main Sep 19, 2023
31 checks passed
@anonrig anonrig deleted the reproduce-nodejs-bug branch September 19, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants