-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to remove ValueProvider #2474
Changes from 4 commits
e33fdb5
fed12ef
fcd4fca
b55cedb
2e4503c
7cee759
cd0f3db
03c9113
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -854,6 +854,13 @@ public class LottieAnimationLayer: CALayer { | |||||
animationLayer.setValueProvider(valueProvider, keypath: keypath) | ||||||
} | ||||||
|
||||||
public func removeValueProvider(for keypath: AnimationKeypath) { | ||||||
guard let animationLayer = rootAnimationLayer else { return } | ||||||
|
||||||
valueProviders[keypath] = nil | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess we should also do something like this here:
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||||||
animationLayer.removeValueProvider(for: keypath) | ||||||
} | ||||||
|
||||||
/// Reads the value of a property specified by the Keypath. | ||||||
/// Returns nil if no property is found. | ||||||
/// | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like I mentioned in #2474 (comment), I think this behavior is different than the behavior implemented for the Core Animation rendering engine in
ValueProviderStore
.layer.nodeProperties(for: keypath)
returns all of the properties that match the given key path, so for example if you add a provider withLayer.Color
and then callremoveValueProvider(for: "**.Color")
, this implementation will remove the provider forLayer.Color
(but the implementation in the Core Animation rendering engine will not).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong preference on which approach is better (removing all matches, or just removing exact matches) but I think the behavior of the Core Animation engine and Main Thread engine needs to be the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a feeling updating the behavior of
ValueProviderStore
to check for matches (usingkeypath.matches(...)
instead of==
) would be easier than trying to change the implementation here to check for exact matches on the original input key path (which I don't think we have access to anymore).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @calda, for your assistance!