-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destinations cdk: implement snapshotting spec test #45468
Merged
edgao
merged 1 commit into
issue-9361/load-cdk-with-e2e-dest-post-refactor
from
edgao/spec_test
Sep 20, 2024
Merged
Destinations cdk: implement snapshotting spec test #45468
edgao
merged 1 commit into
issue-9361/load-cdk-with-e2e-dest-post-refactor
from
edgao/spec_test
Sep 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
This was referenced Sep 13, 2024
2 tasks
octavia-squidington-iii
added
area/connectors
Connector related issues
CDK
Connector Development Kit
connectors/destination/e2e-test
labels
Sep 13, 2024
edgao
force-pushed
the
edgao/spec_test
branch
from
September 13, 2024 22:01
678b120
to
82ab723
Compare
edgao
commented
Sep 13, 2024
DestinationSyncMode.APPEND_DEDUP, | ||
) | ||
} | ||
//package io.airbyte.integrations.destination.e2e_test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build is broken, commented this out just for testing purposes
edgao
force-pushed
the
edgao/spec_test
branch
3 times, most recently
from
September 13, 2024 23:48
79e7420
to
c8fa119
Compare
edgao
force-pushed
the
edgao/cdk_integration_tests
branch
from
September 16, 2024 15:56
a708e68
to
7129f7c
Compare
edgao
force-pushed
the
edgao/spec_test
branch
from
September 16, 2024 15:56
c8fa119
to
1006072
Compare
edgao
force-pushed
the
edgao/cdk_integration_tests
branch
from
September 16, 2024 18:28
7129f7c
to
60e7f4c
Compare
edgao
force-pushed
the
edgao/spec_test
branch
2 times, most recently
from
September 16, 2024 18:44
8ce08af
to
b1a901a
Compare
edgao
force-pushed
the
edgao/cdk_integration_tests
branch
2 times, most recently
from
September 16, 2024 23:38
5d48b46
to
dfd289a
Compare
edgao
force-pushed
the
edgao/spec_test
branch
from
September 16, 2024 23:38
b1a901a
to
64b9b27
Compare
This was referenced Sep 16, 2024
edgao
force-pushed
the
edgao/cdk_integration_tests
branch
from
September 16, 2024 23:48
dfd289a
to
cc112ac
Compare
edgao
force-pushed
the
edgao/spec_test
branch
from
September 16, 2024 23:49
64b9b27
to
bb34611
Compare
edgao
force-pushed
the
edgao/cdk_integration_tests
branch
from
September 17, 2024 16:16
cc112ac
to
cf46a03
Compare
edgao
force-pushed
the
edgao/spec_test
branch
2 times, most recently
from
September 17, 2024 16:22
f166b9f
to
d9b9550
Compare
edgao
force-pushed
the
edgao/cdk_integration_tests
branch
from
September 17, 2024 16:34
cf46a03
to
f8e49cf
Compare
edgao
force-pushed
the
edgao/spec_test
branch
from
September 17, 2024 16:34
d9b9550
to
9ebc28b
Compare
edgao
force-pushed
the
edgao/spec_test
branch
from
September 17, 2024 17:10
e52c6bf
to
9964cfd
Compare
postamar
reviewed
Sep 17, 2024
airbyte-cdk/bulk/core/load/src/testFixtures/kotlin/io/airbyte/cdk/test/spec/SpecTest.kt
Outdated
Show resolved
Hide resolved
airbyte-cdk/bulk/core/load/src/testFixtures/kotlin/io/airbyte/cdk/test/spec/SpecTest.kt
Outdated
Show resolved
Hide resolved
airbyte-cdk/bulk/core/load/src/testFixtures/kotlin/io/airbyte/cdk/test/spec/SpecTest.kt
Outdated
Show resolved
Hide resolved
airbyte-cdk/bulk/core/load/src/testFixtures/kotlin/io/airbyte/cdk/test/spec/SpecTest.kt
Outdated
Show resolved
Hide resolved
airbyte-cdk/bulk/core/load/src/testFixtures/kotlin/io/airbyte/cdk/test/spec/SpecTest.kt
Outdated
Show resolved
Hide resolved
airbyte-cdk/bulk/core/load/src/testFixtures/kotlin/io/airbyte/cdk/test/spec/SpecTest.kt
Outdated
Show resolved
Hide resolved
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/format/consts.py
Outdated
Show resolved
Hide resolved
edgao
force-pushed
the
edgao/cdk_integration_tests
branch
from
September 17, 2024 21:45
c2f4b23
to
30b24fb
Compare
edgao
force-pushed
the
edgao/spec_test
branch
from
September 17, 2024 21:46
9964cfd
to
fc0bcd1
Compare
edgao
changed the base branch from
edgao/cdk_integration_tests
to
edgao/formatter_ignore_autogen_file
September 17, 2024 21:46
edgao
force-pushed
the
edgao/spec_test
branch
2 times, most recently
from
September 17, 2024 21:59
7fbe0ae
to
58f564a
Compare
edgao
force-pushed
the
edgao/formatter_ignore_autogen_file
branch
from
September 17, 2024 22:23
cd8fbf0
to
00dee67
Compare
edgao
force-pushed
the
edgao/spec_test
branch
from
September 17, 2024 22:23
58f564a
to
66dc128
Compare
johnny-schmidt
approved these changes
Sep 19, 2024
edgao
force-pushed
the
edgao/formatter_ignore_autogen_file
branch
from
September 19, 2024 21:49
00dee67
to
bba2b8e
Compare
edgao
force-pushed
the
edgao/spec_test
branch
from
September 19, 2024 21:49
66dc128
to
9708552
Compare
edgao
force-pushed
the
edgao/formatter_ignore_autogen_file
branch
from
September 19, 2024 21:54
bba2b8e
to
847ae31
Compare
edgao
force-pushed
the
edgao/spec_test
branch
from
September 19, 2024 21:54
9708552
to
23585e5
Compare
edgao
force-pushed
the
edgao/formatter_ignore_autogen_file
branch
from
September 19, 2024 21:56
847ae31
to
5933033
Compare
edgao
force-pushed
the
edgao/spec_test
branch
from
September 19, 2024 21:56
23585e5
to
ea8314f
Compare
edgao
force-pushed
the
edgao/formatter_ignore_autogen_file
branch
from
September 19, 2024 21:59
5933033
to
586be8b
Compare
edgao
force-pushed
the
edgao/spec_test
branch
from
September 19, 2024 21:59
ea8314f
to
7c7d04d
Compare
edgao
force-pushed
the
edgao/formatter_ignore_autogen_file
branch
from
September 20, 2024 15:24
586be8b
to
d566ad6
Compare
edgao
force-pushed
the
edgao/spec_test
branch
from
September 20, 2024 15:24
7c7d04d
to
d4b2c4e
Compare
edgao
force-pushed
the
edgao/formatter_ignore_autogen_file
branch
from
September 20, 2024 16:42
d566ad6
to
05f6921
Compare
edgao
force-pushed
the
edgao/spec_test
branch
from
September 20, 2024 16:42
d4b2c4e
to
f20b33d
Compare
edgao
force-pushed
the
edgao/spec_test
branch
from
September 20, 2024 18:20
f20b33d
to
9511fda
Compare
edgao
changed the base branch from
edgao/formatter_ignore_autogen_file
to
edgao/cdk_integration_tests
September 20, 2024 18:20
Base automatically changed from
edgao/cdk_integration_tests
to
issue-9361/load-cdk-with-e2e-dest-post-refactor
September 20, 2024 20:02
edgao
merged commit Sep 20, 2024
9511fda
into
issue-9361/load-cdk-with-e2e-dest-post-refactor
24 of 29 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
CDK
Connector Development Kit
connectors/destination/e2e-test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #45632 - CI will fail until that gets released
tl;dr add a test that:
spec
on the connectorexpected_spec.json
expected_spec.json
the original spec.json got deleted at some point in this stack? so I just created a new expected_spec.json - no strong opinion on where to put it, but I wanted it to be more obvious that it's not the "canonical" spec.
other things to note:
class E2eSpecTest: SpecTest()
. I'm pretty sure there's a way to make this work but haven't bothered looking into it yet, and I think this is good enough for now.prettier
, so I excluded the expected_spec.json files from airbyte-ci's format command.I already committed the updated spec, but there's still a few diffs against the original spec. Pasting them here, I think they're all intentional (e.g. changing type, tweaking wording, swapping
example
->examples
)example diff in expected_spec.json: