[red-knot] Migrate is_subtype_of unit tests to Markdown tests
#15469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InSyncWithFoo
requested review from
carljm,
MichaReiser,
AlexWaygood and
sharkdp
as code owners
InSyncWithFoo
changed the title
is_subtype_of unit tests to Markdown testsis_subtype_of unit tests to Markdown tests
|
AlexWaygood
added
testing
InSyncWithFoo
force-pushed
the
rk-pt-is-subtype-of
branch
from
fdfa9f6 to
f3cec45
Compare
sharkdp
reviewed
Jan 14, 2025
crates/red_knot_python_semantic/resources/mdtest/type_properties/is_subtype_of.md
Outdated
Show resolved
Hide resolved
sharkdp
reviewed
Jan 14, 2025
crates/red_knot_python_semantic/resources/mdtest/type_properties/is_subtype_of.md
Outdated
Show resolved
Hide resolved
sharkdp
reviewed
Jan 14, 2025
crates/red_knot_python_semantic/resources/mdtest/type_properties/is_subtype_of.md
Outdated
Show resolved
Hide resolved
sharkdp
reviewed
Jan 14, 2025
crates/red_knot_python_semantic/resources/mdtest/type_properties/is_subtype_of.md
Outdated
Show resolved
Hide resolved
sharkdp
reviewed
Jan 14, 2025
crates/red_knot_python_semantic/resources/mdtest/type_properties/is_subtype_of.md
Outdated
Show resolved
Hide resolved
sharkdp
reviewed
Jan 14, 2025
crates/red_knot_python_semantic/resources/mdtest/type_properties/is_subtype_of.md
Outdated
Show resolved
Hide resolved
sharkdp
reviewed
Jan 14, 2025
crates/red_knot_python_semantic/resources/mdtest/type_properties/is_subtype_of.md
Outdated
Show resolved
Hide resolved
sharkdp
reviewed
Jan 14, 2025
crates/red_knot_python_semantic/resources/mdtest/type_properties/is_subtype_of.md
Outdated
Show resolved
Hide resolved
sharkdp
reviewed
Jan 14, 2025
crates/red_knot_python_semantic/resources/mdtest/type_properties/is_subtype_of.md
Show resolved
Hide resolved
sharkdp
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Thank you very much!
I think we can probably extend these tests and potentially organize them a little better now that it's easier to do so, but this does not (should not?) happen in this PR. I added a couple of review comments, but I'm also happy to merge this as a "pure refactoring" PR and incorporate these improvements myself as a follow up. Let me know what you think.
|
@sharkdp Please go right ahead! It would be rather unproductive for me to perform such organizational changes. |
sharkdp
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #15397.
Test Plan
Markdown tests.