-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix dependabot, commit & check Cargo.toml #5065
Merged
Merged
+95
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goatgoose
reviewed
Jan 28, 2025
jmayclin
reviewed
Jan 30, 2025
goatgoose
reviewed
Jan 30, 2025
Co-authored-by: Sam Clark <[email protected]>
goatgoose
approved these changes
Jan 30, 2025
jmayclin
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
resolves #4986
Description of changes:
Based on my experiment, simply excluding
s2n-tls-sys
fromdependabot.yml
cannot prevent dependabot retrieving the Cargo file. Hence we decided to commits2n-tls-sys/Cargo.toml
and add a new job inci_rust.yml
to check if the file is up-to-date. Furthermore, testing showed that generated feature list may have a different order from the committedCargo.toml
, thus I added asort()
to the source codegenerate/src/main.rs
.Below is a list of changed files:
dependabot.yml
ci_rust.yml
to check ifs2n-tls-sys/Cargo.toml
is up-to-date in future PRsextended/.gitignore
and committeds2n-tls-sys/Cargo.toml
generate/src/main.rs
Call-outs:
None
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.