[CSR-2066] feat: get full test suite from JSON file #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelangaranocurrents
requested review from
twk3
and removed request for
twk3
vCaisim
requested changes
Feb 7, 2025
| @@ -16,8 +16,16 @@ export async function readJsonFile<T>(filePath: string): Promise<T> { | |||
|
|
|||
| export async function writeFileAsync(filePath: string, content: string) { | |||
| try { | |||
| await fs.writeFile(filePath, content, 'utf8'); | |||
| return filePath; | |||
There was a problem hiding this comment.
Conflict with the changes in #139
| @@ -1,21 +1,7 @@ | |||
| import fs from 'fs-extra'; | |||
There was a problem hiding this comment.
Conflict with the changes in #139
| @@ -223,7 +223,7 @@ function getMarkerFilePath(reportDir: string) { | |||
| return path.join(reportDir, 'upload.marker.json'); | |||
There was a problem hiding this comment.
Conflict with the changes in #139
|
Closing PR as everything is addressed and improved in #139 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the full test suite creation in the upload command for the JUnit scanner. It will only read a JSON file with the full test suite.
PR Checklist
Release Plan
Demo
https://www.loom.com/share/6e9720910f224ff68cb93863f09659bb?sid=97690a7b-93e5-4e30-a99b-dea791962c77
Manual Testing