-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CSR-2066] feat: get full test suite from JSON file #138
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,7 @@ | ||
import fs from 'fs-extra'; | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Conflict with the changes in #139 |
||
import { debug as _debug } from '@debug'; | ||
import { dim, error } from '@logger'; | ||
import { join } from 'path'; | ||
import { parseStringPromise } from 'xml2js'; | ||
import { | ||
TestCase, | ||
TestSuite, | ||
TestSuites, | ||
} from '../../../../services/convert/types'; | ||
import { | ||
ensureArray, | ||
generateTestId, | ||
getSuiteName, | ||
getTestTitle, | ||
} from '../../../../services/convert/utils'; | ||
import { FullSuiteProject, FullSuiteTest, FullTestSuite } from '../types'; | ||
import fs from 'fs-extra'; | ||
import { getFullTestSuiteFilePath } from '../../../../services/upload'; | ||
|
||
const debug = _debug.extend('junit-discovery'); | ||
|
||
|
@@ -25,56 +11,16 @@ export async function jUnitScanner(reportDir: string) { | |
try { | ||
debug('running scanner: %o', reportDir); | ||
|
||
// jUnitFile is the path to the JUnit xml file with all the tests suite and results | ||
const xmlFilePath = join(reportDir, 'currents.results.xml'); | ||
// jUnitFile is the path to the JUnit JSON file with the full test suite data | ||
const fullTestSuitePath = getFullTestSuiteFilePath(reportDir); | ||
|
||
// eslint-disable-next-line turbo/no-undeclared-env-vars | ||
process.env.CURRENTS_DISCOVERY_PATH = xmlFilePath; | ||
process.env.CURRENTS_DISCOVERY_PATH = fullTestSuitePath; | ||
|
||
const fileContent = fs.readFileSync(xmlFilePath, 'utf-8'); | ||
const fileContent = fs.readFileSync(fullTestSuitePath, 'utf-8'); | ||
|
||
const jsonContent = await parseStringPromise(fileContent, { | ||
explicitArray: false, | ||
mergeAttrs: true, | ||
}); | ||
|
||
return parseToFullTestSuite(jsonContent); | ||
return JSON.parse(fileContent); | ||
} catch (err) { | ||
error('Failed to obtain the junit full test suite:', err); | ||
return []; | ||
} | ||
} | ||
|
||
function parseToFullTestSuite(jsonContent: TestSuites) { | ||
const fullTestSuite: FullTestSuite = []; | ||
|
||
const testsuites = ensureArray<TestSuite>(jsonContent.testsuites?.testsuite); | ||
|
||
const fullSuiteProject: FullSuiteProject = { | ||
name: jsonContent.testsuites?.name ?? 'No name', | ||
tags: [], | ||
tests: [], | ||
}; | ||
|
||
testsuites?.forEach((suite) => { | ||
const suiteName = getSuiteName(suite, testsuites); | ||
const testcases = ensureArray<TestCase>(suite?.testcase); | ||
|
||
testcases?.forEach((testcase) => { | ||
const fullSuiteTest: FullSuiteTest = { | ||
title: getTestTitle(testcase.name, suiteName), | ||
spec: suiteName, | ||
tags: [], | ||
testId: generateTestId( | ||
getTestTitle(testcase.name, suiteName).join(', '), | ||
suiteName | ||
), | ||
}; | ||
|
||
fullSuiteProject.tests.push(fullSuiteTest); | ||
}); | ||
}); | ||
fullTestSuite.push(fullSuiteProject); | ||
|
||
return fullTestSuite; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -223,7 +223,7 @@ function getMarkerFilePath(reportDir: string) { | |
return path.join(reportDir, 'upload.marker.json'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Conflict with the changes in #139 |
||
} | ||
|
||
function getFullTestSuiteFilePath(reportDir: string) { | ||
export function getFullTestSuiteFilePath(reportDir: string) { | ||
return path.join(reportDir, 'fullTestSuite.json'); | ||
} | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conflict with the changes in #139