Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSR-2066] feat: get full test suite from JSON file #138

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/cmd/src/lib/fs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,16 @@ export async function readJsonFile<T>(filePath: string): Promise<T> {

export async function writeFileAsync(filePath: string, content: string) {
try {
await fs.writeFile(filePath, content, 'utf8');
return filePath;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflict with the changes in #139

// Check if file exists
try {
await fs.access(filePath);
// If we reach here, file exists
return filePath;
} catch {
// File doesn't exist, create it
await fs.writeFile(filePath, content, 'utf8');
return filePath;
}
} catch (err) {
error(`Error writing file at ${filePath}:`, err);
throw err;
Expand Down
68 changes: 7 additions & 61 deletions packages/cmd/src/services/upload/discovery/junit/scanner.ts
Original file line number Diff line number Diff line change
@@ -1,21 +1,7 @@
import fs from 'fs-extra';

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflict with the changes in #139

import { debug as _debug } from '@debug';
import { dim, error } from '@logger';
import { join } from 'path';
import { parseStringPromise } from 'xml2js';
import {
TestCase,
TestSuite,
TestSuites,
} from '../../../../services/convert/types';
import {
ensureArray,
generateTestId,
getSuiteName,
getTestTitle,
} from '../../../../services/convert/utils';
import { FullSuiteProject, FullSuiteTest, FullTestSuite } from '../types';
import fs from 'fs-extra';
import { getFullTestSuiteFilePath } from '../../../../services/upload';

const debug = _debug.extend('junit-discovery');

Expand All @@ -25,56 +11,16 @@ export async function jUnitScanner(reportDir: string) {
try {
debug('running scanner: %o', reportDir);

// jUnitFile is the path to the JUnit xml file with all the tests suite and results
const xmlFilePath = join(reportDir, 'currents.results.xml');
// jUnitFile is the path to the JUnit JSON file with the full test suite data
const fullTestSuitePath = getFullTestSuiteFilePath(reportDir);

// eslint-disable-next-line turbo/no-undeclared-env-vars
process.env.CURRENTS_DISCOVERY_PATH = xmlFilePath;
process.env.CURRENTS_DISCOVERY_PATH = fullTestSuitePath;

const fileContent = fs.readFileSync(xmlFilePath, 'utf-8');
const fileContent = fs.readFileSync(fullTestSuitePath, 'utf-8');

const jsonContent = await parseStringPromise(fileContent, {
explicitArray: false,
mergeAttrs: true,
});

return parseToFullTestSuite(jsonContent);
return JSON.parse(fileContent);
} catch (err) {
error('Failed to obtain the junit full test suite:', err);
return [];
}
}

function parseToFullTestSuite(jsonContent: TestSuites) {
const fullTestSuite: FullTestSuite = [];

const testsuites = ensureArray<TestSuite>(jsonContent.testsuites?.testsuite);

const fullSuiteProject: FullSuiteProject = {
name: jsonContent.testsuites?.name ?? 'No name',
tags: [],
tests: [],
};

testsuites?.forEach((suite) => {
const suiteName = getSuiteName(suite, testsuites);
const testcases = ensureArray<TestCase>(suite?.testcase);

testcases?.forEach((testcase) => {
const fullSuiteTest: FullSuiteTest = {
title: getTestTitle(testcase.name, suiteName),
spec: suiteName,
tags: [],
testId: generateTestId(
getTestTitle(testcase.name, suiteName).join(', '),
suiteName
),
};

fullSuiteProject.tests.push(fullSuiteTest);
});
});
fullTestSuite.push(fullSuiteProject);

return fullTestSuite;
}
2 changes: 1 addition & 1 deletion packages/cmd/src/services/upload/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ function getMarkerFilePath(reportDir: string) {
return path.join(reportDir, 'upload.marker.json');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflict with the changes in #139

}

function getFullTestSuiteFilePath(reportDir: string) {
export function getFullTestSuiteFilePath(reportDir: string) {
return path.join(reportDir, 'fullTestSuite.json');
}

Expand Down
Loading