ci: codspeed walltime #2294
ci: codspeed walltime #2294
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2294 +/- ##
==========================================
+ Coverage 96.05% 96.19% +0.14%
==========================================
Files 17 17
Lines 1418 1418
==========================================
+ Hits 1362 1364 +2
+ Misses 56 54 -2 ☔ View full report in Codecov by Sentry. |
📝 WalkthroughWalkthroughThe pull request modifies the workflow configuration in Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
.github/workflows/benchmark.yml (1)
Line range hint
24-25: Add descriptive names to the installation steps.Consider adding names to the installation steps for better workflow visibility.
- - run: pip install uv - - run: uv pip install --system -e .[test] + - name: Install uv package manager + run: pip install uv + - name: Install package dependencies + run: uv pip install --system -e .[test]🧰 Tools
🪛 actionlint
18-18: label "codspeed-macro" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-14.0", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-13.0", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "macos-12.0", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
.github/workflows/benchmark.yml(1 hunks)
🧰 Additional context used
🪛 actionlint
.github/workflows/benchmark.yml
18-18: label "codspeed-macro" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-14.0", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-13.0", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "macos-12.0", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🔇 Additional comments (1)
.github/workflows/benchmark.yml (1)
Line range hint 26-29: LGTM! CodSpeed integration is properly configured.
The benchmark setup correctly:
- Uses the latest CodSpeed action version
- Includes proper authentication
- Runs pytest with the required --codspeed flag
🧰 Tools
🪛 actionlint
18-18: label "codspeed-macro" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-14.0", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-13.0", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "macos-12.0", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
| name: Benchmark with codspeed | ||
| if: ${{ github.repository_owner == 'deepmodeling' }} | ||
| runs-on: codspeed-macro |
There was a problem hiding this comment.
💡 Codebase verification
Action Required: Configure CODSPEED_TOKEN Repository Secret
The workflow is correctly configured to use CodSpeed's custom runner and token, but the required CODSPEED_TOKEN secret is not set in the repository. This token is necessary for the benchmark workflow to authenticate with CodSpeed's service.
- Add the
CODSPEED_TOKENsecret to your repository settings - You can obtain the token from your CodSpeed dashboard
🔗 Analysis chain
LGTM! Job configuration aligns with CodSpeed's requirements.
The changes appropriately:
- Restrict the benchmark to run only for the main repository
- Use CodSpeed's custom runner environment
Let's verify the repository configuration:
Let me verify if the CodSpeed token is used in the workflow file:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify repository settings for CodSpeed integration
# Check if CODSPEED_TOKEN secret is configured
gh secret list 2>/dev/null | grep CODSPEED_TOKEN || echo "Warning: CODSPEED_TOKEN secret not found"
Length of output: 129
Script:
#!/bin/bash
# Check if CODSPEED_TOKEN is referenced in the workflow
rg -U "CODSPEED_TOKEN|codspeed/codspeed-benchmark-action" .github/workflows/benchmark.yml
Length of output: 136
🧰 Tools
🪛 actionlint
18-18: label "codspeed-macro" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-14.0", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-13.0", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "macos-12.0", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
See https://docs.codspeed.io/instruments/walltime/#usage-with-github-actions
Summary by CodeRabbit
codspeed-macro.