Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: codspeed walltime #2294

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

ci: codspeed walltime #2294

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c6fbcb
ci: codspeed walltime
njzjz Oct 31, 2024
253e6cf
fix runs-on
njzjz Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@ concurrency:
name: Benchmark
jobs:
test:
name: Test with tox
runs-on: ubuntu-latest
name: Benchmark with codspeed
if: ${{ github.repository_owner == 'deepmodeling' }}
runs-on: codspeed-macro
Comment on lines +16 to +18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Action Required: Configure CODSPEED_TOKEN Repository Secret

The workflow is correctly configured to use CodSpeed's custom runner and token, but the required CODSPEED_TOKEN secret is not set in the repository. This token is necessary for the benchmark workflow to authenticate with CodSpeed's service.

  • Add the CODSPEED_TOKEN secret to your repository settings
  • You can obtain the token from your CodSpeed dashboard
🔗 Analysis chain

LGTM! Job configuration aligns with CodSpeed's requirements.

The changes appropriately:

  • Restrict the benchmark to run only for the main repository
  • Use CodSpeed's custom runner environment

Let's verify the repository configuration:

Let me verify if the CodSpeed token is used in the workflow file:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify repository settings for CodSpeed integration
# Check if CODSPEED_TOKEN secret is configured
gh secret list 2>/dev/null | grep CODSPEED_TOKEN || echo "Warning: CODSPEED_TOKEN secret not found"

Length of output: 129

Script:

#!/bin/bash
# Check if CODSPEED_TOKEN is referenced in the workflow
rg -U "CODSPEED_TOKEN|codspeed/codspeed-benchmark-action" .github/workflows/benchmark.yml

Length of output: 136

🧰 Tools
🪛 actionlint

18-18: label "codspeed-macro" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-14.0", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-13.0", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "macos-12.0", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
Expand Down
Loading