New C-S-S webcompat intervention: modifyLocalStorage #1026

dharb · 2024-09-08T13:45:58Z

Adds new webcompat intervention to modify localStorage entries on specified domains. At the moment delete is the only action implemented, but extensibility is there to add other actions (create, update) if necessary in the future. This feature is only enabled on iOS & Android.

Asana Task/Github Issue: https://app.asana.com/0/246491496396031/1207836782368191/f
Corresponding privacy config changes: duckduckgo/privacy-configuration#2283

Testing steps:
There are a couple ways to test this:
Option A (easiest): Run the integration tests included in this PR to check against the privacy test page also included in this PR

Checkout this branch, run npm i then run npm run test-int. This will use puppeteer to check that the tests here succeed.

Option B:

Clone https://github.com/duckduckgo/privacy-test-pages and in package.json, point https://github.com/duckduckgo/privacy-test-pages/blob/main/package.json#L24 at this branch and npm i
Start the privacy test page local server by running npm run start from that directory
Create an iOS or Android dev build pointing C-S-S at this branch and privacy configuration at New C-S-S webcompat intervention: modifyLocalStorage privacy-configuration#2283 and run it on the simulator
From the simulator, navigate to localhost:3000/content-scope-scripts/webcompat/pages/modify-localstorage.html and see that tests are green
Alternatively, from the simulator, navigate to any old MSN article page and refresh the page two or more times. See that the Expand Article button persists across reloads.

netlify · 2024-09-08T13:46:23Z

✅ Deploy Preview for release-notes-preview canceled.

Name	Link
🔨 Latest commit	`fe5da2e`
🔍 Latest deploy log	https://app.netlify.com/sites/release-notes-preview/deploys/66ddad38f8def3000884303d

github-actions · 2024-09-08T13:51:19Z

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Branch Name: pr-releases/pr-1026
Commit Hash: f6f1e7505562fef8d55b09a9efea2aac75a7b27d
Install Command: npm i github:duckduckgo/content-scope-scripts#f6f1e7505562fef8d55b09a9efea2aac75a7b27d

Please use the above install command to update to the latest version.

github-actions · 2024-09-08T13:58:14Z

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Branch Name: pr-releases/pr-1026
Commit Hash: e0bd7299134f075edac068357933126860f7cd92
Install Command: npm i github:duckduckgo/content-scope-scripts#e0bd7299134f075edac068357933126860f7cd92

Please use the above install command to update to the latest version.

github-actions · 2024-09-08T14:02:31Z

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Branch Name: pr-releases/pr-1026
Commit Hash: 2e3d6bc3f8e96a58e4c8fcef2d34cd645d32156a
Install Command: npm i github:duckduckgo/content-scope-scripts#2e3d6bc3f8e96a58e4c8fcef2d34cd645d32156a

Please use the above install command to update to the latest version.

src/features/web-compat.js

github-actions · 2024-09-18T16:19:43Z

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Branch Name: pr-releases/pr-1026
Commit Hash: 38de564971c1596c793fbfc49a69e6cc40f6a686
Install Command: npm i github:duckduckgo/content-scope-scripts#38de564971c1596c793fbfc49a69e6cc40f6a686

Please use the above install command to update to the latest version.

github-actions · 2024-09-18T16:23:11Z

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Branch Name: pr-releases/pr-1026
Commit Hash: ce8518bd5a885b0a5fb025de772ba043227c7200
Install Command: npm i github:duckduckgo/content-scope-scripts#ce8518bd5a885b0a5fb025de772ba043227c7200

Please use the above install command to update to the latest version.

github-actions · 2024-09-18T16:26:56Z

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Branch Name: pr-releases/pr-1026
Commit Hash: f9180ce9e77c3dbd322723f629cb46d7b3d41605
Install Command: npm i github:duckduckgo/content-scope-scripts#f9180ce9e77c3dbd322723f629cb46d7b3d41605

Please use the above install command to update to the latest version.

github-actions · 2024-09-18T16:58:25Z

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Branch Name: pr-releases/pr-1026
Commit Hash: c34799f89ae6821decd14f0dbe0ef6af9929767c
Install Command: npm i github:duckduckgo/content-scope-scripts#c34799f89ae6821decd14f0dbe0ef6af9929767c

Please use the above install command to update to the latest version.

github-actions · 2024-09-18T17:00:16Z

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Branch Name: pr-releases/pr-1026
Commit Hash: 0a02df586e8661f8d5b0c2f9540916961d4f4666
Install Command: npm i github:duckduckgo/content-scope-scripts#0a02df586e8661f8d5b0c2f9540916961d4f4666

Please use the above install command to update to the latest version.

github-actions · 2024-09-19T00:10:52Z

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Branch Name: pr-releases/pr-1026
Commit Hash: 27a7e04614e3ccd46420783dee10f9f6e7a2ab79
Install Command: npm i github:duckduckgo/content-scope-scripts#27a7e04614e3ccd46420783dee10f9f6e7a2ab79

Please use the above install command to update to the latest version.

github-actions · 2024-09-19T00:11:30Z

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Branch Name: pr-releases/pr-1026
Commit Hash: 9ffcd9db9a3346b7bbe0e8b38af01db35fb3294d
Install Command: npm i github:duckduckgo/content-scope-scripts#9ffcd9db9a3346b7bbe0e8b38af01db35fb3294d

Please use the above install command to update to the latest version.

dharb · 2024-09-19T00:13:01Z

@jonathanKingston I got the privacy test page up and running and integration tests are passing locally, but something else seems to be going awry in CI - seeing a lot of Test timeout of 30000ms exceeded., not sure what's causing it.

Also made the changes we discussed to have /content-scope-scripts/webcompat/ be a directory of webcompat test pages. Want to give this a review when you get a chance?

dharb · 2024-09-19T00:19:11Z

package.json

@@ -70,7 +70,7 @@
    "@types/chrome": "^0.0.248",
    "@types/jasmine": "^5.1.4",
    "@typescript-eslint/eslint-plugin": "^6.9.1",
-    "config-builder": "github:duckduckgo/privacy-configuration#main",
+    "config-builder": "github:duckduckgo/privacy-configuration#dharb/modify-localstorage-config",


I'll flip this back once the config PR is merged.

github-actions · 2024-09-19T17:24:02Z

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Branch Name: pr-releases/pr-1026
Commit Hash: c55f5c7a52af53eac6b6565c2afc6cdabcaadbcf
Install Command: npm i github:duckduckgo/content-scope-scripts#c55f5c7a52af53eac6b6565c2afc6cdabcaadbcf

Please use the above install command to update to the latest version.

jonathanKingston · 2024-09-19T17:57:02Z

integration-test/test-pages/webcompat/pages/modify-localstorage.html

+
+    <script>
+        // eslint-disable-next-line no-undef
+        test('Only specified localStorage entry should be removed', async () => {


Can we add a test for a key that is also isn't present but the code deletes?

This what you meant? https://github.com/duckduckgo/content-scope-scripts/pull/1026/files#diff-e8831dd92f5392a706f73b95990ac32c67e92544a34d094b502d63db301aad9eR27-R34 and line 28 below

src/features/web-compat.js

src/types/webcompat-settings.d.ts

github-actions · 2024-09-19T18:47:55Z

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Branch Name: pr-releases/pr-1026
Commit Hash: 33117870486361dfca5eabba3442e2ed586740c3
Install Command: npm i github:duckduckgo/content-scope-scripts#33117870486361dfca5eabba3442e2ed586740c3

Please use the above install command to update to the latest version.

github-actions · 2024-09-19T18:57:26Z

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Branch Name: pr-releases/pr-1026
Commit Hash: 06b4a9de1efc8b247607b06a02cec034e6578bf9
Install Command: npm i github:duckduckgo/content-scope-scripts#06b4a9de1efc8b247607b06a02cec034e6578bf9

Please use the above install command to update to the latest version.

add new function to delete specified localStorage entries

1fc473a

dharb requested review from jonathanKingston and shakyShane as code owners September 8, 2024 13:45

dharb changed the title ~~New C-S-S webcompat intervention: modifyLocalStorage~~ (WIP) New C-S-S webcompat intervention: modifyLocalStorage Sep 8, 2024

dharb added 2 commits September 8, 2024 09:52

Update webcompat-settings.d.ts

70ae715

didn't read instructions :/

fe5da2e

jonathanKingston reviewed Sep 8, 2024

View reviewed changes

src/features/web-compat.js Show resolved Hide resolved

dharb added 2 commits September 18, 2024 12:14

Update webcompat-settings.d.ts

10a22a3

Update webcompat-settings.d.ts

a40c410

Merge branch 'main' into dharb/modify-localstorage

0b1e6cc

dharb added 2 commits September 18, 2024 12:52

actually fix tests

61cceb5

add modified package-lock.json

9ee2097

dharb and others added 2 commits September 18, 2024 20:05

add modify-localStorage privacy test page

54da104

Merge branch 'main' into dharb/modify-localstorage

e37e70a

dharb commented Sep 19, 2024

View reviewed changes

dharb and others added 2 commits September 19, 2024 09:56

Merge branch 'main' into dharb/modify-localstorage

7eb0ed5

fix paths in message-handlers.html

3a23f5f

dharb changed the title ~~(WIP) New C-S-S webcompat intervention: modifyLocalStorage~~ New C-S-S webcompat intervention: modifyLocalStorage Sep 19, 2024

jonathanKingston reviewed Sep 19, 2024

View reviewed changes

src/features/web-compat.js Outdated Show resolved Hide resolved

jonathanKingston reviewed Sep 19, 2024

View reviewed changes

src/types/webcompat-settings.d.ts Outdated Show resolved Hide resolved

improve modify-localstorage types

d70f89f

one more int test for a key that isn't present

1742dd0

dharb mentioned this pull request Sep 19, 2024

New C-S-S webcompat intervention: modifyLocalStorage duckduckgo/privacy-configuration#2283

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New C-S-S webcompat intervention: modifyLocalStorage #1026

New C-S-S webcompat intervention: modifyLocalStorage #1026

dharb commented Sep 8, 2024 •

edited

Loading

netlify bot commented Sep 8, 2024 •

edited

Loading

github-actions bot commented Sep 8, 2024

github-actions bot commented Sep 8, 2024

github-actions bot commented Sep 8, 2024

github-actions bot commented Sep 18, 2024

github-actions bot commented Sep 18, 2024

github-actions bot commented Sep 18, 2024

github-actions bot commented Sep 18, 2024

github-actions bot commented Sep 18, 2024

github-actions bot commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

dharb commented Sep 19, 2024 •

edited

Loading

dharb Sep 19, 2024

github-actions bot commented Sep 19, 2024

jonathanKingston Sep 19, 2024

dharb Sep 19, 2024 •

edited

Loading

github-actions bot commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

New C-S-S webcompat intervention: modifyLocalStorage #1026

Are you sure you want to change the base?

New C-S-S webcompat intervention: modifyLocalStorage #1026

Conversation

dharb commented Sep 8, 2024 • edited Loading

netlify bot commented Sep 8, 2024 • edited Loading

✅ Deploy Preview for release-notes-preview canceled.

github-actions bot commented Sep 8, 2024

Temporary Branch Update

github-actions bot commented Sep 8, 2024

Temporary Branch Update

github-actions bot commented Sep 8, 2024

Temporary Branch Update

github-actions bot commented Sep 18, 2024

Temporary Branch Update

github-actions bot commented Sep 18, 2024

Temporary Branch Update

github-actions bot commented Sep 18, 2024

Temporary Branch Update

github-actions bot commented Sep 18, 2024

Temporary Branch Update

github-actions bot commented Sep 18, 2024

Temporary Branch Update

github-actions bot commented Sep 19, 2024

Temporary Branch Update

github-actions bot commented Sep 19, 2024

Temporary Branch Update

dharb commented Sep 19, 2024 • edited Loading

dharb Sep 19, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 19, 2024

Temporary Branch Update

jonathanKingston Sep 19, 2024

Choose a reason for hiding this comment

dharb Sep 19, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Sep 19, 2024

Temporary Branch Update

github-actions bot commented Sep 19, 2024

Temporary Branch Update

dharb commented Sep 8, 2024 •

edited

Loading

netlify bot commented Sep 8, 2024 •

edited

Loading

dharb commented Sep 19, 2024 •

edited

Loading

dharb Sep 19, 2024 •

edited

Loading