Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New C-S-S webcompat intervention: modifyLocalStorage #2283

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

dharb
Copy link
Collaborator

@dharb dharb commented Sep 8, 2024

@dharb dharb added the DO NOT MERGE Don't merge this branch unless directed label Sep 8, 2024
@dharb dharb requested review from a team as code owners September 8, 2024 13:38
Copy link

github-actions bot commented Sep 8, 2024

Generated file outputs:

legacy
fingerprinting.json (39 more)
  • fingerprinting.json
  • protections.json
  • trackers-unprotected-temporary.txt
  • trackers-whitelist-temporary.txt
  • v1/extension-brave-config.json
  • v1/extension-bravemv3-config.json
  • v1/extension-chrome-config.json
  • v1/extension-chromemv3-config.json
  • v1/extension-config.json
  • v1/extension-edg-config.json
  • v1/extension-edge-config.json
  • v1/extension-edgmv3-config.json
  • v1/extension-firefox-config.json
  • v1/extension-safarimv3-config.json
  • v1/macos-config.json
  • v1/windows-config.json
  • v2/extension-brave-config.json
  • v2/extension-bravemv3-config.json
  • v2/extension-chrome-config.json
  • v2/extension-chromemv3-config.json
  • v2/extension-config.json
  • v2/extension-edg-config.json
  • v2/extension-edge-config.json
  • v2/extension-edgmv3-config.json
  • v2/extension-firefox-config.json
  • v2/extension-safarimv3-config.json
  • v2/macos-config.json
  • v2/windows-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/macos-config.json
  • v3/windows-config.json

⚠️ File is identical

v1/android-config.json (2 more)
  • v1/android-config.json
  • v2/android-config.json
  • v3/android-config.json
--- v3/android-config.json
+++ v3/android-config.json
@@ -11299,8 +11299,34 @@
                                     "state": "enabled"
                                 }
                             }
                         ]
+                    },
+                    {
+                        "domain": "msn.com",
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/modifyLocalStorage/changes/-",
+                                "value": {
+                                    "key": "continuousReadingOnAppState",
+                                    "action": "delete"
+                                }
+                            }
+                        ]
+                    },
+                    {
+                        "domain": "privacy-test-pages.site",
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/modifyLocalStorage/changes/-",
+                                "value": {
+                                    "key": "keyToBeDeleted",
+                                    "action": "delete"
+                                }
+                            }
+                        ]
                     }
                 ],
                 "notification": {
                     "state": "enabled"
@@ -11393,9 +11419,13 @@
                 "presentation": "enabled",
                 "viewportWidth": "enabled",
                 "webShare": "enabled",
                 "screenLock": "enabled",
-                "plainTextViewPort": "enabled"
+                "plainTextViewPort": "enabled",
+                "modifyLocalStorage": {
+                    "state": "enabled",
+                    "changes": []
+                }
             }
         },
         "webViewBlobDownload": {
             "exceptions": [],
v1/ios-config.json (2 more)
  • v1/ios-config.json
  • v2/ios-config.json
  • v3/ios-config.json
--- v3/ios-config.json
+++ v3/ios-config.json
@@ -10271,8 +10271,12 @@
                         ],
                         "undefined": []
                     }
                 },
+                "modifyLocalStorage": {
+                    "state": "enabled",
+                    "changes": []
+                },
                 "domains": [
                     {
                         "domain": "www.cbsnews.com",
                         "patchSettings": [
@@ -10291,8 +10295,34 @@
                                 "path": "/messageHandlers/state",
                                 "value": "enabled"
                             }
                         ]
+                    },
+                    {
+                        "domain": "msn.com",
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/modifyLocalStorage/changes/-",
+                                "value": {
+                                    "key": "continuousReadingOnAppState",
+                                    "action": "delete"
+                                }
+                            }
+                        ]
+                    },
+                    {
+                        "domain": "privacy-test-pages.site",
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/modifyLocalStorage/changes/-",
+                                "value": {
+                                    "key": "keyToBeDeleted",
+                                    "action": "delete"
+                                }
+                            }
+                        ]
                     }
                 ]
             }
         },
latest
v4/android-config.json
--- v4/android-config.json
+++ v4/android-config.json
@@ -10304,8 +10304,34 @@
                                     "state": "enabled"
                                 }
                             }
                         ]
+                    },
+                    {
+                        "domain": "msn.com",
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/modifyLocalStorage/changes/-",
+                                "value": {
+                                    "key": "continuousReadingOnAppState",
+                                    "action": "delete"
+                                }
+                            }
+                        ]
+                    },
+                    {
+                        "domain": "privacy-test-pages.site",
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/modifyLocalStorage/changes/-",
+                                "value": {
+                                    "key": "keyToBeDeleted",
+                                    "action": "delete"
+                                }
+                            }
+                        ]
                     }
                 ],
                 "notification": {
                     "state": "enabled"
@@ -10398,9 +10424,13 @@
                 "presentation": "enabled",
                 "viewportWidth": "enabled",
                 "webShare": "enabled",
                 "screenLock": "enabled",
-                "plainTextViewPort": "enabled"
+                "plainTextViewPort": "enabled",
+                "modifyLocalStorage": {
+                    "state": "enabled",
+                    "changes": []
+                }
             }
         },
         "webViewBlobDownload": {
             "exceptions": [],
v4/extension-brave-config.json (11 more)
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/macos-config.json
  • v4/windows-config.json

⚠️ File is identical

v4/ios-config.json
--- v4/ios-config.json
+++ v4/ios-config.json
@@ -9312,8 +9312,12 @@
                         ],
                         "undefined": []
                     }
                 },
+                "modifyLocalStorage": {
+                    "state": "enabled",
+                    "changes": []
+                },
                 "domains": [
                     {
                         "domain": "www.cbsnews.com",
                         "patchSettings": [
@@ -9332,8 +9336,34 @@
                                 "path": "/messageHandlers/state",
                                 "value": "enabled"
                             }
                         ]
+                    },
+                    {
+                        "domain": "msn.com",
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/modifyLocalStorage/changes/-",
+                                "value": {
+                                    "key": "continuousReadingOnAppState",
+                                    "action": "delete"
+                                }
+                            }
+                        ]
+                    },
+                    {
+                        "domain": "privacy-test-pages.site",
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/modifyLocalStorage/changes/-",
+                                "value": {
+                                    "key": "keyToBeDeleted",
+                                    "action": "delete"
+                                }
+                            }
+                        ]
                     }
                 ]
             }
         },

Copy link
Member

@federicocappelli federicocappelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from what I know, but I have no idea how to test this PR

Copy link

Generated file outputs:

legacy
fingerprinting.json (39 more)
  • fingerprinting.json
  • protections.json
  • trackers-unprotected-temporary.txt
  • trackers-whitelist-temporary.txt
  • v1/extension-brave-config.json
  • v1/extension-bravemv3-config.json
  • v1/extension-chrome-config.json
  • v1/extension-chromemv3-config.json
  • v1/extension-config.json
  • v1/extension-edg-config.json
  • v1/extension-edge-config.json
  • v1/extension-edgmv3-config.json
  • v1/extension-firefox-config.json
  • v1/extension-safarimv3-config.json
  • v1/macos-config.json
  • v1/windows-config.json
  • v2/extension-brave-config.json
  • v2/extension-bravemv3-config.json
  • v2/extension-chrome-config.json
  • v2/extension-chromemv3-config.json
  • v2/extension-config.json
  • v2/extension-edg-config.json
  • v2/extension-edge-config.json
  • v2/extension-edgmv3-config.json
  • v2/extension-firefox-config.json
  • v2/extension-safarimv3-config.json
  • v2/macos-config.json
  • v2/windows-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/macos-config.json
  • v3/windows-config.json

⚠️ File is identical

v1/android-config.json (2 more)
  • v1/android-config.json
  • v2/android-config.json
  • v3/android-config.json
--- v3/android-config.json
+++ v3/android-config.json
@@ -11371,8 +11371,34 @@
                                     "state": "enabled"
                                 }
                             }
                         ]
+                    },
+                    {
+                        "domain": "msn.com",
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/modifyLocalStorage/changes/-",
+                                "value": {
+                                    "key": "continuousReadingOnAppState",
+                                    "action": "delete"
+                                }
+                            }
+                        ]
+                    },
+                    {
+                        "domain": "privacy-test-pages.site",
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/modifyLocalStorage/changes/-",
+                                "value": {
+                                    "key": "keyToBeDeleted",
+                                    "action": "delete"
+                                }
+                            }
+                        ]
                     }
                 ],
                 "notification": {
                     "state": "enabled"
@@ -11465,9 +11491,13 @@
                 "presentation": "enabled",
                 "viewportWidth": "enabled",
                 "webShare": "enabled",
                 "screenLock": "enabled",
-                "plainTextViewPort": "enabled"
+                "plainTextViewPort": "enabled",
+                "modifyLocalStorage": {
+                    "state": "enabled",
+                    "changes": []
+                }
             }
         },
         "webViewBlobDownload": {
             "exceptions": [],
v1/ios-config.json (2 more)
  • v1/ios-config.json
  • v2/ios-config.json
  • v3/ios-config.json
--- v3/ios-config.json
+++ v3/ios-config.json
@@ -10346,8 +10346,12 @@
                         ],
                         "undefined": []
                     }
                 },
+                "modifyLocalStorage": {
+                    "state": "enabled",
+                    "changes": []
+                },
                 "domains": [
                     {
                         "domain": "www.cbsnews.com",
                         "patchSettings": [
@@ -10366,8 +10370,34 @@
                                 "path": "/messageHandlers/state",
                                 "value": "enabled"
                             }
                         ]
+                    },
+                    {
+                        "domain": "msn.com",
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/modifyLocalStorage/changes/-",
+                                "value": {
+                                    "key": "continuousReadingOnAppState",
+                                    "action": "delete"
+                                }
+                            }
+                        ]
+                    },
+                    {
+                        "domain": "privacy-test-pages.site",
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/modifyLocalStorage/changes/-",
+                                "value": {
+                                    "key": "keyToBeDeleted",
+                                    "action": "delete"
+                                }
+                            }
+                        ]
                     }
                 ]
             }
         },
latest
v4/android-config.json
--- v4/android-config.json
+++ v4/android-config.json
@@ -10370,8 +10370,34 @@
                                     "state": "enabled"
                                 }
                             }
                         ]
+                    },
+                    {
+                        "domain": "msn.com",
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/modifyLocalStorage/changes/-",
+                                "value": {
+                                    "key": "continuousReadingOnAppState",
+                                    "action": "delete"
+                                }
+                            }
+                        ]
+                    },
+                    {
+                        "domain": "privacy-test-pages.site",
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/modifyLocalStorage/changes/-",
+                                "value": {
+                                    "key": "keyToBeDeleted",
+                                    "action": "delete"
+                                }
+                            }
+                        ]
                     }
                 ],
                 "notification": {
                     "state": "enabled"
@@ -10464,9 +10490,13 @@
                 "presentation": "enabled",
                 "viewportWidth": "enabled",
                 "webShare": "enabled",
                 "screenLock": "enabled",
-                "plainTextViewPort": "enabled"
+                "plainTextViewPort": "enabled",
+                "modifyLocalStorage": {
+                    "state": "enabled",
+                    "changes": []
+                }
             }
         },
         "webViewBlobDownload": {
             "exceptions": [],
v4/extension-brave-config.json (11 more)
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/macos-config.json
  • v4/windows-config.json

⚠️ File is identical

v4/ios-config.json
--- v4/ios-config.json
+++ v4/ios-config.json
@@ -9382,8 +9382,12 @@
                         ],
                         "undefined": []
                     }
                 },
+                "modifyLocalStorage": {
+                    "state": "enabled",
+                    "changes": []
+                },
                 "domains": [
                     {
                         "domain": "www.cbsnews.com",
                         "patchSettings": [
@@ -9402,8 +9406,34 @@
                                 "path": "/messageHandlers/state",
                                 "value": "enabled"
                             }
                         ]
+                    },
+                    {
+                        "domain": "msn.com",
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/modifyLocalStorage/changes/-",
+                                "value": {
+                                    "key": "continuousReadingOnAppState",
+                                    "action": "delete"
+                                }
+                            }
+                        ]
+                    },
+                    {
+                        "domain": "privacy-test-pages.site",
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/modifyLocalStorage/changes/-",
+                                "value": {
+                                    "key": "keyToBeDeleted",
+                                    "action": "delete"
+                                }
+                            }
+                        ]
                     }
                 ]
             }
         },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Don't merge this branch unless directed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants