Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test new error handling indicating when the sandbox is not found #540

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Test new error handling indicating when the sandbox is not found #540

wants to merge 10 commits into from
+78 −20

Conversation

0div
Copy link
Contributor

@0div 0div commented Jan 16, 2025

Added a test in js-sdk for e2b-dev/infra#231

@linear Linear
Copy link

linear bot commented Jan 16, 2025

E2B-1327 Return error indicating that the sandbox is not running when making requests from SDK

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 16, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 06ef257

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@0div 0div mentioned this pull request Jan 16, 2025
Merged
2 tasks
jakubno
jakubno requested changes Jan 16, 2025
View reviewed changes
Copy link
Member

@jakubno jakubno left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we do the same for Python?

packages/js-sdk/tests/sandbox/host.test.ts Outdated Show resolved Hide resolved
packages/js-sdk/tests/sandbox/host.test.ts Outdated Show resolved Hide resolved
@0div
Copy link
Contributor Author

0div commented Jan 16, 2025

Could we do the same for Python?

This is more of an integration test rather than a unit test, do you think it's necessary?

@0div
Copy link
Contributor Author

0div commented Jan 16, 2025

Could we do the same for Python?

This is more of an integration test rather than a unit test, do you think it's necessary?

@jakubno maybe relevant to that comment: #519

@0div 0div requested a review from mlejva as a code owner January 18, 2025 01:21
@ValentaTomas ValentaTomas added the Improvement Improvement for current functionality label Jan 18, 2025
@0div 0div force-pushed the return-error-indicating-that-the-sandbox-is-not-running-when-e2b-1327-test branch from f0def1b to a9c283e Compare January 18, 2025 01:48
@0div 0div requested a review from jakubno January 18, 2025 01:55
jakubno
jakubno requested changes Jan 18, 2025
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
packages/js-sdk/package.json Outdated Show resolved Hide resolved
packages/js-sdk/package.json Outdated Show resolved Hide resolved
packages/js-sdk/tests/sandbox/commands/sendStdin.test.ts Outdated Show resolved Hide resolved
packages/js-sdk/tests/sandbox/host.test.ts Show resolved Hide resolved
packages/js-sdk/tests/sandbox/host.test.ts Outdated Show resolved Hide resolved
packages/js-sdk/tests/sandbox/host.test.ts Outdated Show resolved Hide resolved
packages/js-sdk/tests/sandbox/host.test.ts Outdated Show resolved Hide resolved
packages/js-sdk/tests/sandbox/host.test.ts Outdated Show resolved Hide resolved
@0div
Merge branch 'main' of https://github.com/e2b-dev/E2B into return-err…
7cc525e 
…or-indicating-that-the-sandbox-is-not-running-when-e2b-1327-test
@0div 0div requested a review from jakubno January 18, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValentaTomas ValentaTomas Awaiting requested review from ValentaTomas ValentaTomas is a code owner

@mlejva mlejva Awaiting requested review from mlejva

@jakubno jakubno Awaiting requested review from jakubno jakubno is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@0div 0div

Labels
Improvement Improvement for current functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0div @jakubno @ValentaTomas