Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test new error handling indicating when the sandbox is not found #540

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
4 changes: 3 additions & 1 deletion packages/js-sdk/tests/sandbox/commands/sendStdin.test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { assert } from 'vitest'
import { sandboxTest } from '../../setup.js'
import { sandboxTest, wait } from '../../setup.js'

sandboxTest('send stdin to process', async ({ sandbox }) => {
const text = 'Hello, World!'
Expand Down Expand Up @@ -29,6 +29,8 @@ sandboxTest('send special characters to stdin', async ({ sandbox }) => {

await sandbox.commands.sendStdin(cmd.pid, text)

await wait(5_000)
0div marked this conversation as resolved.
Show resolved Hide resolved

await cmd.kill()

assert.equal(cmd.stdout, text)
Expand Down
24 changes: 23 additions & 1 deletion packages/js-sdk/tests/sandbox/connect.test.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { test, assert } from 'vitest'
import { assert, test } from 'vitest'

import { Sandbox } from '../../src'
import { isDebug, template } from '../setup.js'
Expand All @@ -19,3 +19,25 @@ test('connect', async () => {
}
}
})

test('connect to non-running sandbox', async () => {
const sbx = await Sandbox.create(template, { timeoutMs: 10_000 })
let isKilled = false

try {
const isRunning = await sbx.isRunning()
assert.isTrue(isRunning)
await sbx.kill()
isKilled = true

const sbxConnection = await Sandbox.connect(sbx.sandboxId)
const isRunning2 = await sbxConnection.isRunning()
assert.isFalse(isRunning2)

await sbxConnection.commands.run('echo "hello"')
} finally {
if (!isKilled) {
await sbx.kill()
}
}
})
48 changes: 43 additions & 5 deletions packages/js-sdk/tests/sandbox/host.test.ts
Original file line number Diff line number Diff line change
@@ -1,18 +1,56 @@
import { assert } from 'vitest'

import { isDebug, sandboxTest, wait } from '../setup.js'
import Sandbox from '../../src/index.js'
import { isDebug, sandboxTest, template, wait } from '../setup.js'

sandboxTest('ping server in sandbox', async ({ sandbox }) => {
const cmd = await sandbox.commands.run('python -m http.server 8000', { background: true })
sandboxTest.skipIf(isDebug)(
'ping server in running sandbox',
async ({ sandbox }) => {
const cmd = await sandbox.commands.run('python -m http.server 8000', {
background: true,
})

try {
await wait(10_000)

const host = sandbox.getHost(8000)

const res = await fetch(`${isDebug ? 'http' : 'https'}://${host}`)

assert.equal(res.status, 200)
} finally {
try {
await cmd.kill()
} catch (e) {
console.error(e)
}
}
}
)

sandboxTest.skipIf(isDebug)('ping server in non-running sandbox', async () => {
const sbx = await Sandbox.create(template, { timeoutMs: 120_000 })

const cmd = await sbx.commands.run('python -m http.server 8000', {
background: true,
})

try {
await wait(1000)
await wait(20_000)

const host = sandbox.getHost(8000)
const host = sbx.getHost(8000)

const res = await fetch(`${isDebug ? 'http' : 'https'}://${host}`)

assert.equal(res.status, 200)

await sbx.kill()

const res2 = await fetch(`${isDebug ? 'http' : 'https'}://${host}`)
assert.equal(res2.status, 502)

const text = await res2.text()
assert.equal(text, 'Sandbox does not exist.')
0div marked this conversation as resolved.
Show resolved Hide resolved
} finally {
try {
await cmd.kill()
Expand Down
Loading