Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v2.0.5 release #2126

Conversation

mossmaurice
Copy link
Contributor

@mossmaurice mossmaurice commented Nov 30, 2023

Pre-Review Checklist for the PR Author

  1. Add a second reviewer for complex new features or larger refactorings
  2. Code follows the coding style of CONTRIBUTING.md
  3. Tests follow the best practice for testing
  4. Changelog updated in the unreleased section including API breaking changes
  5. Branch follows the naming format (iox-123-this-is-a-branch)
  6. Commits messages are according to this guideline
  7. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  8. Relevant issues are linked
  9. Add sensible notes for the reviewer
  10. All checks have passed (except task-list-completed)
  11. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  12. Assign PR to reviewer

Notes for Reviewer

  • Prepare v2.0.5 release

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@mossmaurice mossmaurice added the tooling All iceoryx related tooling (scripts etc.) label Nov 30, 2023
@mossmaurice mossmaurice requested a review from dkroenke November 30, 2023 10:01
@mossmaurice mossmaurice self-assigned this Nov 30, 2023
@mossmaurice mossmaurice force-pushed the iox-2099-prepare-v-2-0-5-release branch from 5c69ac2 to 9acd992 Compare November 30, 2023 10:06
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #2126 (a80bd29) into release_2.0 (cdb8615) will decrease coverage by 0.07%.
Report is 1 commits behind head on release_2.0.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release_2.0    #2126      +/-   ##
===============================================
- Coverage        78.90%   78.83%   -0.07%     
===============================================
  Files              370      370              
  Lines            14716    14716              
  Branches          2061     2061              
===============================================
- Hits             11611    11601      -10     
- Misses            2421     2434      +13     
+ Partials           684      681       -3     
Flag Coverage Δ
unittests 78.05% <ø> (-0.07%) ⬇️
unittests_timing 15.50% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@mossmaurice
Copy link
Contributor Author

ROS 2 CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@mossmaurice mossmaurice force-pushed the iox-2099-prepare-v-2-0-5-release branch from 9211777 to b59b3f9 Compare December 4, 2023 10:57
@mossmaurice mossmaurice force-pushed the iox-2099-prepare-v-2-0-5-release branch 2 times, most recently from 6c739e5 to 89304d1 Compare December 4, 2023 11:39
@mossmaurice mossmaurice force-pushed the iox-2099-prepare-v-2-0-5-release branch from 89304d1 to 36f097d Compare December 4, 2023 12:34
@mossmaurice mossmaurice requested a review from dkroenke December 4, 2023 12:34
@mossmaurice mossmaurice force-pushed the iox-2099-prepare-v-2-0-5-release branch from 36f097d to 1172955 Compare December 4, 2023 12:35
@mossmaurice mossmaurice force-pushed the iox-2099-prepare-v-2-0-5-release branch from 1172955 to a80bd29 Compare December 4, 2023 13:16
@mossmaurice
Copy link
Contributor Author

@dkroenke Could you please re-review this PR? 🙏

Copy link
Member

@dkroenke dkroenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mossmaurice mossmaurice merged commit e274957 into eclipse-iceoryx:release_2.0 Dec 4, 2023
@mossmaurice mossmaurice deleted the iox-2099-prepare-v-2-0-5-release branch December 4, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling All iceoryx related tooling (scripts etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants