Allow empty values in the spec #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppalaga
reviewed
Feb 12, 2024
cxw42
force-pushed
the
issue496-allow-empty-values
branch
from
1960baf
to
8c89aca
Compare
|
Updated: rebased on the modified #46. |
Vampire
reviewed
Sep 15, 2024
cxw42
force-pushed
the
issue496-allow-empty-values
branch
from
8c89aca
to
4fffaef
Compare
xuhdev
reviewed
Sep 16, 2024
|
As #46 is through, please rebase continue here. :-) |
cxw42
force-pushed
the
issue496-allow-empty-values
branch
from
4fffaef
to
191d857
Compare
Vampire
reviewed
Sep 25, 2024
cxw42
force-pushed
the
issue496-allow-empty-values
branch
from
191d857
to
02fcf27
Compare
Vampire
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR builds on #46. Please review only the head commit. All other commits are part of #46.
Part of editorconfig/editorconfig#496 .
Update the spec to expressly permit the form
as defining
keywith an empty string as its value. This is different from not definingkeyat all.@ppalaga has written draft tests at editorconfig/editorconfig-core-test#52 .