make random id generation more performant #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Roman Shtylman <[email protected]>
defunctzombie
approved these changes
Jan 24, 2024
pezy
pushed a commit
to pezy/studio
that referenced
this pull request
Sep 14, 2024
Update comlink to 9181fa505671b35b1e66e0a8361a6fc1bdd03307 for performance improvements Includes foxglove/comlink#1 and foxglove/comlink#3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a simpler random id generation which is much more performant, which is especially noticeable when sending many requests in a short time.
Upstream PR: GoogleChromeLabs#654