Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for Brave wallet #828

Merged
merged 15 commits into from
Jan 31, 2024
Merged

feat: add support for Brave wallet #828

merged 15 commits into from
Jan 31, 2024

Conversation

ericleponner
Copy link
Collaborator

Description:

Changes below add support for Brave wallet.
Wallet Chooser dialog now displays an extra button for Brave.
On Brave browser, this button connects to the wallet builtin in Brave.
On other browsers, it simply leads to error message Brave wallet extension not found.

Related issue(s):

Fixes #813

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 85.38% 34457 / 40356
🔵 Statements 85.38% 34457 / 40356
🔵 Functions 65.2% 817 / 1253
🔵 Branches 84.13% 3855 / 4582
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/utils/wallet/WalletDriver_Blade.ts 40.88% 100% 20% 40.88% 52-88, 91-101, 104-105, 112-122, 125-132, 139-152, 155-170, 173-180
src/utils/wallet/WalletDriver_Brave.ts 76.82% 100% 28.57% 76.82% 44-49, 52-55, 58-61, 68-72
src/utils/wallet/WalletManager.ts 65.06% 73.68% 53.33% 65.06% 99-104, 110-115, 122-126, 135-141, 148-149, 151-152, 156-165, 168-177, 180-189, 192-197, 200-205, 208-217
Generated in workflow #696

@ericleponner ericleponner force-pushed the 00813-v2-add-support-for-brave-wallet branch from 780bda2 to 5e821c7 Compare January 10, 2024 11:00
@ericleponner ericleponner force-pushed the 00813-v2-add-support-for-brave-wallet branch 2 times, most recently from 820dec2 to b0c69d1 Compare January 24, 2024 18:56
quiet-node and others added 12 commits January 25, 2024 15:46
@quiet-node @ericleponner
feat: added Brave wallet driver
94835fa 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node @ericleponner
feat: added support for brave wallet in client components
a35ff06 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node @ericleponner
update: removed metamask related materials in Brave driver
ffc819f 
Signed-off-by: Logan Nguyen <[email protected]>
@ericleponner
Moved watchToken() to WalletDriver_Ethereum base class.
8118fd0 
Signed-off-by: Eric Le Ponner <[email protected]>
@ericleponner
WalletDriver_Brave now makes sure ethereum.provider is really brave p…
bc012c2 
…rovider.

Signed-off-by: Eric Le Ponner <[email protected]>
@ericleponner
WalletDriver_Ethereum.isCancelError() has now a generic implementation.
142fd04 
Signed-off-by: Eric Le Ponner <[email protected]>
@ericleponner
Fixed WalletDriver_Brave.disconnect().
7975e9e 
Signed-off-by: Eric Le Ponner <[email protected]>
@ericleponner
Fixed exception processing in WalletDriver_Blade.connect().
efaa7db 
Signed-off-by: Eric Le Ponner <[email protected]>
@ericleponner
WalletDriver_Brave now overrides extensionNotFound() to adapt message…
2575373 
… wording.

Signed-off-by: Eric Le Ponner <[email protected]>
@ericleponner
Fixed some imports and removed dead code.
7773965 
Signed-off-by: Eric Le Ponner <[email protected]>
@ericleponner
TopNavBar and App unit tests now takes new wallet button into account.
46a1e50 
Signed-off-by: Eric Le Ponner <[email protected]>
@ericleponner
Removed (now obsolete) WalletManager.braveWalletRef variable.
a6e851d 
Signed-off-by: Eric Le Ponner <[email protected]>
@ericleponner ericleponner force-pushed the 00813-v2-add-support-for-brave-wallet branch from b0c69d1 to a6e851d Compare January 25, 2024 14:46
@ericleponner ericleponner marked this pull request as ready for review January 31, 2024 17:55
@ericleponner ericleponner requested a review from svienot January 31, 2024 17:55
svienot
svienot approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ericleponner ericleponner merged commit 873d342 into main Jan 31, 2024
6 checks passed
@ericleponner ericleponner deleted the 00813-v2-add-support-for-brave-wallet branch January 31, 2024 18:45
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@ericleponner ericleponner mentioned this pull request Jan 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svienot svienot svienot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add support for brave wallet
3 participants
@ericleponner @svienot @quiet-node