Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Decode Transaction Call Data for Standard EVM Addresses #830

Merged
merged 3 commits into from
Jan 5, 2024
Merged

fix: Decode Transaction Call Data for Standard EVM Addresses #830

merged 3 commits into from
Jan 5, 2024
+648 −6

Conversation

ericleponner
Copy link
Collaborator

Description:

Changes below:

Related issue(s):

Fixes #827

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ericleponner ericleponner requested a review from svienot January 5, 2024 16:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 88.38% 33399 / 37788
🔵 Statements 88.38% 33399 / 37788
🔵 Functions 66.5% 800 / 1203
🔵 Branches 84.46% 3718 / 4402
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/values/FunctionResult.vue 75.21% 50% 100% 75.21% 28-54, 60-61
src/utils/analyzer/ContractResultAnalyzer.ts 97.16% 96.07% 100% 97.16% 107-108, 131-132
Generated in workflow #622

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)
68.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

svienot
svienot approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ericleponner ericleponner merged commit 33e7ac3 into main Jan 5, 2024
4 of 5 checks passed
@ericleponner ericleponner deleted the 00827_decode_std_evm_address branch January 5, 2024 18:49
svienot added a commit that referenced this pull request Jan 8, 2024
@svienot
Revert "fix: Decode Transaction Call Data for Standard EVM Addresses (#…
223c5c9 
…830)"

This reverts commit 33e7ac3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svienot svienot svienot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decode Transaction Call Data for Standard EVM Addresses
2 participants
@ericleponner @svienot