Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Decode Transaction Call Data for Standard EVM Addresses #830

Merged
merged 3 commits into from
Jan 5, 2024
Merged

fix: Decode Transaction Call Data for Standard EVM Addresses #830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2de8d0a
Fixed ContractResultAnalyzer.toId() (solves #827).
ericleponner Jan 5, 2024
a63dd12
Added unit tests for ContractResultAnalyzer.
ericleponner Jan 5, 2024
ae67888
Fixed id of <Property> element in FunctionResult.vue.
ericleponner Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/values/FunctionResult.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@

</template><template v-else>

<Property :custom-nb-col-class="customNbColClass" id="functionInput">
<Property :custom-nb-col-class="customNbColClass" id="functionOutput">
<template v-slot:name>Output Result</template>
<template v-slot:value>
<HexaValue :byte-string="output" :show-none="true"/>
Expand Down
9 changes: 4 additions & 5 deletions src/utils/analyzer/ContractResultAnalyzer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,24 +63,23 @@ export class ContractResultAnalyzer {
})

public readonly toId = computed(() => {
const entityID = EntityID.fromAddress(this.contractResult.value?.to ?? undefined)
return entityID?.toString() ?? null
return this.contractResult.value?.contract_id ?? null
})

public readonly gasPrice = computed(() => {
return (this.contractResult.value?.gas_price !== null)
return this.contractResult.value?.gas_price
? Number(filter0x(this.contractResult.value?.gas_price))
: null
})

public readonly maxFeePerGas = computed(() => {
return (this.contractResult.value?.max_fee_per_gas !== null)
return this.contractResult.value?.max_fee_per_gas
? Number(filter0x(this.contractResult.value?.max_fee_per_gas))
: null
})

public readonly maxPriorityFeePerGas = computed(() => {
return (this.contractResult.value?.max_priority_fee_per_gas !== null)
return this.contractResult.value?.max_priority_fee_per_gas
? Number(filter0x(this.contractResult.value?.max_priority_fee_per_gas))
: null
})
Expand Down
Loading