Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for special chars in yaml #4105

Merged
merged 3 commits into from
Oct 20, 2024
Merged

fix for special chars in yaml #4105

merged 3 commits into from
Oct 20, 2024

Conversation

Dxuian
Copy link
Contributor

@Dxuian Dxuian commented Aug 30, 2024 •
edited
Loading

Resolves #4044

Changes

added special char support to YAML keys via updating regex
before
image
after
image

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md

@github-actions GitHub Actions
Copy link

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

5 files changed

Total change +5 B

View Changes
file base pr diff
es/core.min.js 8.18 KB 8.18 KB +1 B
es/highlight.min.js 8.18 KB 8.18 KB +1 B
es/languages/yaml.min.js 875 B 876 B +1 B
highlight.min.js 8.22 KB 8.22 KB +1 B
languages/yaml.min.js 876 B 877 B +1 B

@Dxuian Dxuian closed this Aug 30, 2024
@Dxuian Dxuian reopened this Aug 30, 2024
@github-actions GitHub Actions
Copy link

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

5 files changed

Total change +5 B

View Changes
file base pr diff
es/core.min.js 8.18 KB 8.18 KB +1 B
es/highlight.min.js 8.18 KB 8.18 KB +1 B
es/languages/yaml.min.js 875 B 876 B +1 B
highlight.min.js 8.22 KB 8.22 KB +1 B
languages/yaml.min.js 876 B 877 B +1 B

@Dxuian Dxuian mentioned this pull request Sep 1, 2024
Open
1 task
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

3 files changed

Total change +3 B

View Changes
file base pr diff
es/languages/yaml.min.js 875 B 876 B +1 B
highlight.min.js 8.22 KB 8.22 KB +1 B
languages/yaml.min.js 876 B 877 B +1 B

@joshgoebel
Copy link
Member

Could we get a special_chars markup test to go with this?

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

5 files changed

Total change -3 B

View Changes
file base pr diff
es/core.min.js 8.18 KB 8.18 KB -2 B
es/highlight.min.js 8.18 KB 8.18 KB -2 B
es/languages/yaml.min.js 875 B 876 B +1 B
highlight.min.js 8.22 KB 8.22 KB -1 B
languages/yaml.min.js 876 B 877 B +1 B

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

3 files changed

Total change +3 B

View Changes
file base pr diff
es/languages/yaml.min.js 875 B 876 B +1 B
highlight.min.js 8.22 KB 8.22 KB +1 B
languages/yaml.min.js 876 B 877 B +1 B

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

2 files changed

Total change +2 B

View Changes
file base pr diff
es/languages/yaml.min.js 875 B 876 B +1 B
languages/yaml.min.js 876 B 877 B +1 B

@Dxuian
Copy link
Contributor Author

Dxuian commented Oct 3, 2024 •
edited
Loading

Could we get a special_chars markup test to go with this?

ive added a special_chars test file please review and close this issue 🙏🙏🙏🙏
(ps if i messed up git please tell me i messed my local copy)
(can you add hacktoberfest to this issue 🙏🙏🙏🙏🙏🙏)

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

5 files changed

Total change +6 B

View Changes
file base pr diff
es/core.min.js 8.18 KB 8.18 KB +1 B
es/highlight.min.js 8.18 KB 8.18 KB +1 B
es/languages/yaml.min.js 875 B 876 B +1 B
highlight.min.js 8.22 KB 8.22 KB +2 B
languages/yaml.min.js 876 B 877 B +1 B

@Dxuian
Copy link
Contributor Author

Dxuian commented Oct 13, 2024

@joshgoebel ?

@github-actions GitHub Actions
Copy link

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

5 files changed

Total change +14 B

View Changes
file base pr diff
es/core.min.js 8.18 KB 8.18 KB +4 B
es/highlight.min.js 8.18 KB 8.18 KB +4 B
es/languages/yaml.min.js 875 B 876 B +1 B
highlight.min.js 8.22 KB 8.22 KB +4 B
languages/yaml.min.js 876 B 877 B +1 B

@joshgoebel joshgoebel merged commit c2d29ac into highlightjs:main Oct 20, 2024
19 checks passed
@joshgoebel
Copy link
Member

@Dxuian Thanks so much!

@Dxuian Dxuian deleted the yaml-fix branch October 20, 2024 23:02
@joshgoebel joshgoebel mentioned this pull request Oct 21, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgoebel joshgoebel joshgoebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(YAML) Expand allowed characters in keys
2 participants
@Dxuian @joshgoebel