Bug fix for withSet in LogicStructure. #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkorbel1
reviewed
Feb 6, 2025
mkorbel1
reviewed
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
Bug in LogicStructure's withSet method where if the "update" value's width is less than the given overlapping field's width within the structure (per the start index of the set), build would crash because the out of bounds guard on the "update" value was incorrectly ignoring the "update" field's width and instead just using the overlapping field's width.
Related Issue(s)
N/A
Testing
Added a single unit test to logic_structure_test that exercises the bug.
Backwards-compatibility
Backwards compatible.
Documentation
No need for doc.