Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: highlight query file #33

Merged
merged 1 commit into from
Feb 4, 2025
Merged

feat: highlight query file #33

merged 1 commit into from
Feb 4, 2025

Conversation

bertbaron
Copy link
Contributor

@bertbaron bertbaron commented Feb 2, 2025

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #32

2. What is the scope of this PR (e.g. component or file name):

kcl-lang/tree-sitter-kcl

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

Adding a highlight.scm

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test

I had to add a (generated) tree-sitter.json and register the .k extension to run the tests, but didn't commit it.

Signed-off-by: Bert Baron <[email protected]>
@maulik13
Copy link

maulik13 commented Feb 3, 2025

Hi, could someone review this? With full highlighting using tree-sitter will make working with KCL in neovim really great.

@Peefy
Copy link
Contributor

Peefy commented Feb 4, 2025

Amazing Job! LGTM!

@Peefy Peefy merged commit ca62a22 into kcl-lang:main Feb 4, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add highlight.scm for syntax highlighting in nvim etc.
3 participants