KEP-4427: Relaxed DNS search validation to beta #5045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
sig/network
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
kind/kep
danwinship
reviewed
Jan 18, 2025
| @@ -4,19 +4,19 @@ authors: | |||
| - "@sethev" | |||
| - "@adrianmoisey" | |||
| owning-sig: sig-network | |||
| status: implementable | |||
| status: implemented | |||
There was a problem hiding this comment.
i forget when you're supposed to change this, but I guess the PRR reviewer will complain if it's wrong 🙂
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: adrianmoisey, danwinship The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line PR description: Updates sections for beta release targeting 1.33
Issue link: Relaxed DNS search string validation #4427
Other comments: This is my first time doing this. I think I covered everything, but forgive me if I missed something
/sig network
/assign aojea danwinship thockin
PRR reviewers:
/assign jpbetz