Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-4427: Relaxed DNS search validation to beta #5045

Merged
merged 1 commit into from
Feb 4, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions keps/prod-readiness/sig-network/4427.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
kep-number: 4427
alpha:
approver: "@jpbetz"
beta:
approver: "@jpbetz"
5 changes: 3 additions & 2 deletions keps/sig-network/4427-relaxed-dns-search-validation/README.md
Original file line number Diff line number Diff line change
@@ -268,7 +268,7 @@ In addition to the Pod itself, each integration test should be repeated with obj
- [X] Initial e2e tests completed and enabled

#### Beta
- [ ] No trouble reports from alpha release
- [X] No trouble reports from alpha release

#### GA
- [ ] No trouble reports with the beta release, plus some anecdotal evidence of it being used successfully.
@@ -385,7 +385,8 @@ Describe manual testing that was done and the outcomes.
Longer term, we may want to require automated upgrade/rollback tests, but we
are missing a bunch of machinery and tooling and can't do that now.
-->
Will be tested during implementation.

Tested by hand.

###### Is the rollout accompanied by any deprecations and/or removals of features, APIs, fields of API types, flags, etc.?

6 changes: 3 additions & 3 deletions keps/sig-network/4427-relaxed-dns-search-validation/kep.yaml
Original file line number Diff line number Diff line change
@@ -4,19 +4,19 @@ authors:
- "@sethev"
- "@adrianmoisey"
owning-sig: sig-network
status: implementable
status: implemented
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i forget when you're supposed to change this, but I guess the PRR reviewer will complain if it's wrong 🙂

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've always set this to implemented after the feature goes GA, but I'm happy to defer to @kubernetes/sig-release.

(I don't consider this field to be under PRR purview. we focus on the PRR section of the readme)

creation-date: 2024-01-22
reviewers:
- "@danwinship"
approvers:
- "@thockin"
# The target maturity stage in the current dev cycle for this KEP.
stage: alpha
stage: beta

# The most recent milestone for which work toward delivery of this KEP has been
# done. This can be the current (upcoming) milestone, if it is being actively
# worked on.
latest-milestone: "v1.32"
latest-milestone: "v1.33"

# The milestone at which this feature was, or is targeted to be, at each stage.
milestone: