Konnectivity Proxy: move proxy-agent cpu limit to request.

[jkh52]

What type of PR is this?

/kind bug
/kind failing-test
/kind flake

What this PR does / why we need it:

While debugging e2e flakes at #102904 (dial timeout cases), we see agents reconnecting. While we don't yet collect agent logs (kubernetes/test-infra#22811), in the meantime these tuning tweaks may increase agent availability and help bring down flakiness.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

@jkh52: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @jkh52. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[caesarxuchao]

Was it intentional to change the cpu to requests but keeping the memory as limits?

[jkh52]

Yes, intentional. I wanted to avoid artificial restrictions from cpu limit, as well as incrementally stay similar to GKE configuration.

[cheftako]

Are we experiencing bursty CPU behavior on the agent?

[jkh52]

Are we experiencing bursty CPU behavior on the agent?

No, this is just a best practice / cleanup (this PR shrank after a rebase but this seems worth keeping).

[rata]

+1 for this change.

Some background on the best practices, just in case: CPU limits, due to some bugs in the kernel in several versions, create throttling when sometimes is not needed. Given the way CFS works, also, when no cpu limits is used and there is contention, cpu will be allocated proportionally to the requests. No cpu limits is quite fine :)

[rata]

And mem limits work fine and you want them. So, changing only cpu limits to requests LGTM

[caesarxuchao]

/lgtm
/approve

[aojea]

/retest
unrelated failures

[caesarxuchao]

/lgtm

[cheftako]

/ok-to-test

[cheftako]

/retest

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[jkh52]

/remove-lifecycle stale

We still want this, and it even came up at kubernetes-sigs/apiserver-network-proxy#261

[aojea]

/retest

👀
pull-kubernetes-e2e-gce-network-proxy-grpc

Kubernetes e2e suite: [sig-storage] In-tree Volumes [Driver: local][LocalVolumeType: tmpfs] [Testpattern: Pre-provisioned PV (default fs)] subPath should support non-existent path expand_less 34s
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/storage/testsuites/subpath.go:194
Nov 4 01:22:53.535: Unexpected error:
<*errors.StatusError | 0xc0034df220>: {
ErrStatus: {
TypeMeta: {Kind: "", APIVersion: ""},
ListMeta: {
SelfLink: "",
ResourceVersion: "",
Continue: "",
RemainingItemCount: nil,
},
Status: "Failure",
Message: "error dialing backend: dial tcp 10.40.0.3:10250: i/o timeout",
Reason: "",
Details: nil,

[cheftako]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, cheftako, jkh52

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cluster/gce/OWNERS [cheftako]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment