Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Konnectivity Proxy: move proxy-agent cpu limit to request. #103626

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Konnectivity Proxy: move proxy-agent cpu limit to request. #103626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cluster/gce/addons/konnectivity-agent/konnectivity-agent-ds.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,9 @@ spec:
fieldRef:
fieldPath: metadata.namespace
resources:
limits:
requests:
cpu: 50m
limits:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it intentional to change the cpu to requests but keeping the memory as limits?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, intentional. I wanted to avoid artificial restrictions from cpu limit, as well as incrementally stay similar to GKE configuration.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we experiencing bursty CPU behavior on the agent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we experiencing bursty CPU behavior on the agent?

No, this is just a best practice / cleanup (this PR shrank after a rebase but this seems worth keeping).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for this change.

Some background on the best practices, just in case: CPU limits, due to some bugs in the kernel in several versions, create throttling when sometimes is not needed. Given the way CFS works, also, when no cpu limits is used and there is contention, cpu will be allocated proportionally to the requests. No cpu limits is quite fine :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And mem limits work fine and you want them. So, changing only cpu limits to requests LGTM

memory: 30Mi
volumeMounts:
- mountPath: /var/run/secrets/tokens
Expand Down