frontend: add confirm action component via context #3230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdslaugh
reviewed
Feb 13, 2025
Comment on lines
+44
to
+49
| <TextField | ||
| label="Confirmation" | ||
| value={input} | ||
| onChange={e => setInput(e.target.value)} | ||
| fullWidth | ||
| /> |
There was a problem hiding this comment.
We may want to leave this as part of the description. We may prefer to have to some workflows with a confirmation but not necessarily requiring an input, so that should be left up to the implementer.
Comment on lines
+31
to
+33
| if (input === confirmationText) { | ||
| onConfirm(); | ||
| } |
There was a problem hiding this comment.
We'll probably want to leave this to the implementer as well. We will likely want a generic reason field versus something specific, better auditing that way.
jecr
changed the title
|
closed in favor of #3231 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a confirmation dialog component and integrates it into the existing wizard component. The main changes include the creation of the
ConfirmActioncomponent and the necessary modifications to theWizardcomponent to utilize this new dialog.Addition of Confirmation Dialog:
frontend/packages/wizard/src/confirm-action.tsx: Created a newConfirmActioncomponent that displays a dialog with a confirmation text input and confirm/cancel buttons.Integration with Wizard Component:
frontend/packages/wizard/src/wizard.tsx:useStateand the newConfirmActioncomponent. [1] [2]showConfirmActionto configure and open theConfirmActiondialog.ConfirmActioncomponent into theWizardcomponent's JSX, passing the necessary props and handling the confirm and cancel actions.